-
Notifications
You must be signed in to change notification settings - Fork 404
[WIP] RFCs #38
[WIP] RFCs #38
Conversation
rfcs/README.md
Outdated
In short, to get a major feature added to React Native, one usually first gets the RFC merged into the RFC repo as a markdown file. At that point the RFC is "active" and may be implemented with the goal of eventual inclusion into React Native. | ||
|
||
- Fork the RFC repo [react-native-community/react-native-releases](http://github.com/react-native-community/react-native-releases) | ||
- Copy `rfcs/0000-template.md` to `rfcs/0000-my-feature.md` (where 'my-feature' is the title in kebab case; don't assign an RFC number yet). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe change rfcs/0000-my-feature.md
to rfcs/XXXX-my-feature.md
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The RFC number isn't known until the PR is made; they wont know it yet.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes it was simply to "make more clear" that is was still an undefined number. No strong opinions anyway
rfcs/README.md
Outdated
|
||
Each week the team will attempt to review some set of open RFC pull requests. | ||
|
||
We try to make sure that any RFC that we accept is accepted at the Friday team meeting, and reported in [core team notes]. Every accepted feature should have a core team champion, who will represent the feature and its progress. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Friday team meeting?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops! Leak :)
Left a couple comments here, but overall 100% solid and I like it. Side things:
|
I agree with moving the changelog to a separate directory, however I do believe that it stay unified in one file. This is consistent with most other projects. I do think there's more progress to be made on streamlining the changelog though. I like the idea of converting For Discussion to RFCs; I fear however that if we move them over for users, they may not feel ownership of them. I'd suggest instead incentivising users to move them. The filtered PR link should show all of the open ones. I'm open to tracking statuses in another way, especially if it can include more context for the change (like the summary). |
Gotcha. That's fine then.
I'll double check if there is a way of "migrating" an issue from a repo to another, but yeah I see what you mean.
My idea behind having a "recap" was more like, to allow people to have a quick overview since it's probably the closest thing to a roadmap we could have on the OSS side. |
Got input outside of Github that we should consider this less of a strict RFC approach and instead as broader planning and proposals. Going to do some revs tonight with that in mind. |
I didn't get through changes to the proposal template, but I did update a draft of the README this evening. |
let's close this in favour of https://github.com/react-native-community/discussions-and-proposals ? |
This is an early draft of a proposed RFC repo and process. It's very very similar to what exists today on React. I'm still researching other RFC processes and trying to incorporate additional improvements. If there's any early feedback on this, feel free to share or even directly make a change if you're so compelled.