This repository has been archived by the owner on Jun 17, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elicwhite
reviewed
Oct 18, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a couple comments for potential improvements to the generator to make this easier for the future
lunaleaps
reviewed
Oct 18, 2021
fabOnReact
reviewed
Oct 25, 2021
oblador
reviewed
Oct 31, 2021
oblador
reviewed
Oct 31, 2021
oblador
reviewed
Oct 31, 2021
oblador
reviewed
Oct 31, 2021
oblador
reviewed
Oct 31, 2021
cortinico
reviewed
Oct 31, 2021
facebook-github-bot
pushed a commit
to facebook/react-native
that referenced
this pull request
Nov 2, 2021
Summary: As agreed, we are moving back the changelog from the RNC repo into the core one. This PR does just that. It will be followed up by a new draft PR for the 0.67 release ([old one](react-native-community/releases#255)). Once this is merged, a few links will need to be fixed, such as: * https://github.com/facebook/react-native/wiki/Changelog * https://github.com/facebook/react-native/releases (for new releases) Moreover, we should have a conversation about how changes are reported for the "monorepo" part of this repo: https://github.com/facebook/react-native/tree/main/packages as far as I can see, the changes to those packages are not documented anywhere. ## Changelog [Internal] [Added] - Adding Changelog.md back into main repo Pull Request resolved: #32520 Test Plan: N/A Reviewed By: lunaleaps Differential Revision: D32102055 Pulled By: cortinico fbshipit-source-id: 6d1f353bb6acdc952e40941510ca36200690bbf8
Co-authored-by: Joel Arvidsson <joel@oblador.se>
Co-authored-by: Joel Arvidsson <joel@oblador.se>
Co-authored-by: Joel Arvidsson <joel@oblador.se>
Co-authored-by: Joel Arvidsson <joel@oblador.se>
kelset
force-pushed
the
chore/067-release
branch
from
November 3, 2021 12:00
6feba8a
to
b0c9bc0
Compare
Closing this in favour of facebook/react-native#32529, the feedback on the generator has been recorded here to make sure we won't lose it: #257 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generated via the script, from 0.66.1 to 0.67-rc.0.
NEEDS TO BE CLEANED UP