0.55.x Discussion

[grabbou]

Please report any major issues and commits to cherry-pick in this thread for discussion.

[gengjiawen]

The android ci is still broken in master branch, which stuck my pr.Can you push to this fixed ? I tried but I know few about buck.

[turnrye]

Hey @gengjiawen, we're aware of the issue with CI and a fix is in progress.

[asowayan]

@grabbou This commit fixes a regression that broke our app (the issue was introduced with 0.54). It would be great if this fix is in the 0.55 release.

facebook/react-native@15fa225

[gengjiawen]

@turnrye It is still broken, I don't think it's a small problem because it stuck all community pr getting merged. I really wish we can fix it asap.

[grabbou]

Yeah, I am going to spend some time this week making it green because I need to cut next release branch.

Meanwhile, yet another cherry-pick request to consider: facebook/react-native#18223 (comment)

[dannycochran]

@grabbou

Fixes an issue with invertStickyHeaders not being passed to ScrollView from SectionList / FlatList:

facebook/react-native#18524

[gengjiawen]

Hopefully the ci thing will be fixed in next week :(

[grabbou]

All prior commits have been cherry-picked and we are releasing stable version now.

[kelset]

Hey @grabbou looks like there's a Metro issue: facebook/react-native#18681 (comment)

[grabbou]

Yeah, seems to be the case. I'll look into it before making a new one.

…

On Wed, 4 Apr 2018 at 17:32 Lorenzo Sciandra ***@***.***> wrote: Hey @grabbou <https://github.com/grabbou> looks like there's a Metro issue: facebook/react-native#18681 (comment) <facebook/react-native#18681 (comment)> — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#11 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ACWcxkMURKT248kCKcqgdoWqqFxNwihOks5tlOeZgaJpZM4S1W_m> .

[kelset]

Looks like there is a PR in the making which should fix that: facebook/react-native#18700