Skip to content

Update App.tsx to correspond to def typed updates #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 12, 2019
Merged

Update App.tsx to correspond to def typed updates #55

merged 1 commit into from
Aug 12, 2019

Conversation

orta
Copy link
Member

@orta orta commented Aug 1, 2019

Re: facebook/react-native#25882 and DefinitelyTyped/DefinitelyTyped#37303

Will allow the default app to compile out of the box.

emin93
emin93 approved these changes Aug 12, 2019
View reviewed changes
Copy link
Member

@emin93 emin93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR and sorry for the delayed review.

@emin93 emin93 merged commit eae5bed into master Aug 12, 2019
@emin93
Copy link
Member

emin93 commented Aug 12, 2019

Released in https://github.com/react-native-community/react-native-template-typescript/releases/tag/5.2.1

@orta
Copy link
Member Author

orta commented Aug 12, 2019

No worries, thanks!

@emin93 emin93 deleted the orta-patch-1 branch September 11, 2019 09:12
@radko93 radko93 mentioned this pull request Sep 26, 2019
Merged
@radko93
Copy link
Collaborator

radko93 commented Sep 26, 2019

@orta does this actually work? Because when you run this on iOS HermesInternal is {} and that is not true? It's just checking the type.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emin93 emin93 emin93 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@orta @emin93 @radko93