Skip to content

Extend recommended React Native TSConfig base #281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jun 30, 2022
Merged

Extend recommended React Native TSConfig base #281

merged 8 commits into from
Jun 30, 2022

Conversation

leotm
Copy link
Contributor

@leotm leotm commented Jun 29, 2022

Context

To keep our recommended React Native TSConfig base as the source


yarn set version classic

  • Add devdep
  • Extend
  • Doc
  • Remove ts --init comment boilerplate (can still remove further)
  • Remove es2019 override
  • Remove forceConsistentCasingInFileNames override

Have a think if skipLibCheck should be recommended for React Native, we do in few others

Remove duplicate rule overrides
Keep duplicate rule overrides for visibility

@radko93
Copy link
Collaborator

radko93 commented Jun 30, 2022

Hi, can you update this branch with master and see if it runs the lint action?

@leotm
Copy link
Contributor Author

leotm commented Jun 30, 2022

sure ^ how do you feel about what @orta mentioned btw

@leotm leotm marked this pull request as ready for review June 30, 2022 11:39
@leotm leotm requested review from emin93 and radko93 as code owners June 30, 2022 11:39
@leotm
Copy link
Contributor Author

leotm commented Jun 30, 2022

also considering if it's ideal for each dupe (non-unique) config to be commented (that it's extended) for visibility

Screenshot 2022-06-30 at 12 38 52

or for simplicity remove the dupes alltogether

@orta
Copy link
Member

orta commented Jun 30, 2022

Yeah, IMO, you should present an empty tsconfig if you're going with the extends

@leotm
Copy link
Contributor Author

leotm commented Jun 30, 2022

from messing around earlier

Preview: (Extended) Screenshot 2022-06-30 at 15 53 28

but sure an empty tsconfig w extends makes sense, i'll go ahead and remove the tsc --init commented boilerplate

@leotm
Copy link
Contributor Author

leotm commented Jun 30, 2022

done ^ much more minimal

Screenshot 2022-06-30 at 16 11 20

happy to remove the rest of the comments still if we want near-fully empty tsconfig

@leotm
Copy link
Contributor Author

leotm commented Jun 30, 2022

and happy to remove any overrides like es2019 once merged in
https://github.com/tsconfig/bases/blob/main/bases/react-native.json

@radko93
Copy link
Collaborator

radko93 commented Jun 30, 2022

LGTM, great work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants