Skip to content

Fix lib to use iOS 10.x and Android JSC #164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 13, 2021

Conversation

newyankeecodeshop
Copy link
Contributor

@newyankeecodeshop newyankeecodeshop commented Sep 29, 2020

Summary

Now that React Native 0.63 requires iOS 10.x, and bundles a modern version of JSC on Android, we can update the JavaScript library version to es2017. That brings in declarations for:

  • Array.prototype.includes
  • Object.entries and Object.values
  • String.padStart and String.padEnd

Also, the version of Node that React Native requires, 10.x, also supports these APIs.

Test Plan

Ran yarn run tsc in the template application and no errors were found.

What's required for testing (prerequisites)?

N/A

What are the steps to reproduce (after prerequisites)?

N/A

Compatibility

OS Implemented
iOS
Android

Checklist

  • I have tested this on a device and a simulator
  • I added the documentation in README.md
  • I mentioned this change in CHANGELOG.md
  • I updated the typed files (TS and Flow)
  • I added a sample use of the API in the example project (example/App.js)

@newyankeecodeshop newyankeecodeshop changed the title Fix lib to use iOS 10.x JSC base and remove DOM declarations Fix lib to use iOS 10.x and Android JSC Sep 29, 2020
@newyankeecodeshop
Copy link
Contributor Author

@radko93 @emin93 This has been open several months. Is anyone going to review it or should I just close it?

Copy link
Member

@emin93 emin93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for pinging and the patience. Of course this makes sense to include, so I approved it.

@emin93 emin93 merged commit c2c3961 into react-native-community:master Feb 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants