Skip to content

feat: update react-native to 0.63.2 and @types/react-native to 0.63.2 #153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

abakimatov
Copy link
Contributor

@abakimatov abakimatov commented Jul 29, 2020

Summary

Update versions of react-native and @types/react-native to 0.63.2 version

Checklist

  • I have tested this on a device and a simulator
  • I added the documentation in README.md
  • I mentioned this change in CHANGELOG.md
  • I updated the typed files (TS and Flow)
  • I added a sample use of the API in the example project (example/App.js)

@emin93
Copy link
Member

emin93 commented Jul 31, 2020

Upgrading from 0.63.0 to 0.63.2 requires some changes in the gradle and Xcode project. Can you include those changes as well? (https://react-native-community.github.io/upgrade-helper/?from=0.63.0&to=0.63.2)

You can merge the changes over from here e.g. by copying over the android & iOS folder: https://github.com/facebook/react-native/tree/v0.63.2/template

@abakimatov
Copy link
Contributor Author

Oh my bad. Ofc, i can :)

@abakimatov
Copy link
Contributor Author

Guys, i also added .idea config directory to gitignore, because this directory was added to my commit. I hope this won't be a problem. Sorry for a little messy pull request. )

@radko93
Copy link
Collaborator

radko93 commented Aug 3, 2020

@abakimatov if you added it but it was not there before please remove it

@emin93
Copy link
Member

emin93 commented Aug 3, 2020

This has way too many changes, should have only 3 changed files in total (package.json, android/app/build.gradle and ios/RnDiffApp.xcodeproj/project.pbxproj). Are you sure you didn't modify anything after copying over the latest template?

… for ios. Also added .idea config directory to gitignore.
@abakimatov abakimatov force-pushed the feat/updateToRN0.63.2 branch from 479ed68 to c577207 Compare August 3, 2020 16:43
@abakimatov
Copy link
Contributor Author

@abakimatov if you added it but it was not there before please remove it

i removed it in the last commit, but if you want,

@abakimatov abakimatov closed this Aug 3, 2020
@abakimatov abakimatov reopened this Aug 3, 2020
@abakimatov
Copy link
Contributor Author

abakimatov commented Aug 3, 2020

Okay guys, my bad, sorry, now i was just copied build.gradle and project.pbxproj from original latest template here. Also .idea directory was be added to .gitignore. And i was clean my commits history.

@radko93
Copy link
Collaborator

radko93 commented Aug 4, 2020

If you look at this https://react-native-community.github.io/upgrade-helper/?from=0.63.0&to=0.63.2 there's no .idea file added

@abakimatov
Copy link
Contributor Author

If you look at this https://react-native-community.github.io/upgrade-helper/?from=0.63.0&to=0.63.2 there's no .idea file added

okay, i removed it

Copy link
Member

@emin93 emin93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now, thanks 😄

@emin93 emin93 merged commit 4f47540 into react-native-community:master Aug 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants