Skip to content

Update tsconfig.json #125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 27, 2020
Merged

Update tsconfig.json #125

merged 1 commit into from
Mar 27, 2020

Conversation

leotm
Copy link
Contributor

@leotm leotm commented Mar 26, 2020

Summary

Screenshot 2020-03-23 at 00 10 10

To give the community a better first-time experience getting up and running.

We should either leave noEmit on like in create-react-app (i.e. Revert #100), or can amend this PR to only incremental left on, but with the outDir as e.g. "./lib", add this to the exclude list (since the compiler doesn't exclude it by default unless you include e.g. ./src) then finally add our /lib to .gitignore.

Test Plan

What's required for testing (prerequisites)?

  • npx --ignore-existing react-native init MyApp --template react-native-template-typescript
  • cd MyApp

What are the steps to reproduce (after prerequisites)?

  • yarn tsc

Compatibility

OS Implemented
iOS ✅❌
Android ✅❌

Checklist

  • I have tested this on a device and a simulator
  • I added the documentation in README.md
  • I mentioned this change in CHANGELOG.md
  • I updated the typed files (TS and Flow)
  • I added a sample use of the API in the example project (example/App.js)

@leotm leotm requested review from emin93 and radko93 as code owners March 26, 2020 12:12
@emin93 emin93 merged commit 95a17b2 into react-native-community:master Mar 27, 2020
@leotm leotm deleted the patch-1 branch March 27, 2020 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants