Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fix made to handle if mode in command argument includes build flavor … #2324

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: Fix made to handle if mode in command argument includes build flavor … #2324

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions packages/cli-platform-android/src/commands/runAndroid/tryInstallAppOnDevice.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,10 +16,10 @@ function tryInstallAppOnDevice(
// "app" is usually the default value for Android apps with only 1 app
const {appName, sourceDir} = androidProject;

const defaultVariant = (args.mode || 'debug').toLowerCase();
const defaultVariant = 'debug';

// handle if selected task from interactive mode includes build flavour as well, eg. installProductionDebug should create ['production','debug'] array
const variantFromSelectedTask = selectedTask
// handle if selected task from interactive mode, or mode from arguments, includes build flavour as well, eg. installProductionDebug should create ['production','debug'] array
const variantFromSelectedTask = (selectedTask ?? args.mode)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@szymonrybczak @adamTrz should we do the fallback here or set selectedTask to args.mode in non-interactive mode, if that makes sense?

?.replace('install', '')
.split(/(?=[A-Z])/);

Expand Down
Loading