-
Notifications
You must be signed in to change notification settings - Fork 905
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Upgrade metro dependencies to 0.76.2 #1910
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robhogan
reviewed
Apr 14, 2023
robhogan
approved these changes
Apr 14, 2023
@@ -89,19 +89,15 @@ export default async function loadMetroConfig( | |||
|
|||
const projectConfig = await resolveConfig(undefined, ctx.root); | |||
|
|||
// @ts-ignore resolveConfig return value is mistyped |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🥳
@thymikee - Are you happy for the Metro team to go ahead and merge PRs like this? |
szymonrybczak
approved these changes
Apr 17, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🙌
thymikee
approved these changes
Apr 17, 2023
huntie
pushed a commit
to huntie/react-native
that referenced
this pull request
Apr 18, 2023
Summary: This is follow up of Metro release 0.76.2 to Bump versions in RN. Metro version: 0.76.2 Metro release notes: https://github.com/facebook/metro/releases/tag/v0.76.2 CLI Bump PR: react-native-community/cli#1910 CLI npm version: 12.0.0-alpha.3 Took changelog and testplan from facebook#36793 ## Changelog: [General][Fixed] - Bump CLI to 12.0.0-alpha.3 and Metro to 0.76.2 Pull Request resolved: facebook#36948 Test Plan: CircleCI Differential Revision: D45081058 Pulled By: jacdebug fbshipit-source-id: dd7af7ff6b44d6d71eb2970c6198787a3d13931c
huntie
pushed a commit
to huntie/react-native
that referenced
this pull request
Apr 18, 2023
Summary: This is follow up of Metro release 0.76.2 to Bump versions in RN. Metro version: 0.76.2 Metro release notes: https://github.com/facebook/metro/releases/tag/v0.76.2 CLI Bump PR: react-native-community/cli#1910 CLI npm version: 12.0.0-alpha.3 Took changelog and testplan from facebook#36793 ## Changelog: [General][Fixed] - Bump CLI to 12.0.0-alpha.3 and Metro to 0.76.2 Pull Request resolved: facebook#36948 Test Plan: CircleCI Differential Revision: D45081058 Pulled By: jacdebug fbshipit-source-id: 0326fc407fe52809f75d07f26b23f5a7e69a3900
jacdebug
added a commit
to facebook/react-native
that referenced
this pull request
Apr 18, 2023
Summary: This is follow up of Metro release 0.76.2 to Bump versions in RN. Metro version: 0.76.2 Metro release notes: https://github.com/facebook/metro/releases/tag/v0.76.2 CLI Bump PR: react-native-community/cli#1910 CLI npm version: 12.0.0-alpha.3 Took changelog and testplan from #36793 ## Changelog: [General][Fixed] - Bump CLI to 12.0.0-alpha.3 and Metro to 0.76.2 Pull Request resolved: #36948 Test Plan: CircleCI Reviewed By: huntie Differential Revision: D45081058 Pulled By: jacdebug fbshipit-source-id: 261329a04d9d222293cca18bc915ee3345c05d70
jacdebug
added a commit
to facebook/react-native
that referenced
this pull request
Apr 18, 2023
Summary: This is follow up of Metro release 0.76.2 to Bump versions in RN. Metro version: 0.76.2 Metro release notes: https://github.com/facebook/metro/releases/tag/v0.76.2 CLI Bump PR: react-native-community/cli#1910 CLI npm version: 12.0.0-alpha.3 Took changelog and testplan from #36793 ## Changelog: [General][Fixed] - Bump CLI to 12.0.0-alpha.3 and Metro to 0.76.2 Pull Request resolved: #36948 Test Plan: CircleCI Reviewed By: huntie Differential Revision: D45081058 Pulled By: jacdebug fbshipit-source-id: 88eccf5afd742146f77ff9be01faa16e75e68a8b
facebook-github-bot
pushed a commit
to facebook/react-native
that referenced
this pull request
Apr 18, 2023
Summary: This is follow up of Metro release 0.76.2 to Bump versions in RN. Metro version: 0.76.2 Metro release notes: https://github.com/facebook/metro/releases/tag/v0.76.2 CLI Bump PR: react-native-community/cli#1910 CLI npm version: 12.0.0-alpha.3 Took changelog and testplan from #36793 ## Changelog: [General][Fixed] - Bump CLI to 12.0.0-alpha.3 and Metro to 0.76.2 Pull Request resolved: #36948 Test Plan: CircleCI Reviewed By: huntie Differential Revision: D45081058 Pulled By: jacdebug fbshipit-source-id: 4c7b1004668ac30045577da54311bcab1a905ca9
jeongshin
pushed a commit
to jeongshin/react-native
that referenced
this pull request
May 7, 2023
Summary: This is follow up of Metro release 0.76.2 to Bump versions in RN. Metro version: 0.76.2 Metro release notes: https://github.com/facebook/metro/releases/tag/v0.76.2 CLI Bump PR: react-native-community/cli#1910 CLI npm version: 12.0.0-alpha.3 Took changelog and testplan from facebook#36793 ## Changelog: [General][Fixed] - Bump CLI to 12.0.0-alpha.3 and Metro to 0.76.2 Pull Request resolved: facebook#36948 Test Plan: CircleCI Reviewed By: huntie Differential Revision: D45081058 Pulled By: jacdebug fbshipit-source-id: 4c7b1004668ac30045577da54311bcab1a905ca9
OlimpiaZurek
pushed a commit
to OlimpiaZurek/react-native
that referenced
this pull request
May 22, 2023
Summary: This is follow up of Metro release 0.76.2 to Bump versions in RN. Metro version: 0.76.2 Metro release notes: https://github.com/facebook/metro/releases/tag/v0.76.2 CLI Bump PR: react-native-community/cli#1910 CLI npm version: 12.0.0-alpha.3 Took changelog and testplan from facebook#36793 ## Changelog: [General][Fixed] - Bump CLI to 12.0.0-alpha.3 and Metro to 0.76.2 Pull Request resolved: facebook#36948 Test Plan: CircleCI Reviewed By: huntie Differential Revision: D45081058 Pulled By: jacdebug fbshipit-source-id: 4c7b1004668ac30045577da54311bcab1a905ca9
blakef
pushed a commit
to blakef/template
that referenced
this pull request
Feb 28, 2024
Summary: This is follow up of Metro release 0.76.2 to Bump versions in RN. Metro version: 0.76.2 Metro release notes: https://github.com/facebook/metro/releases/tag/v0.76.2 CLI Bump PR: react-native-community/cli#1910 CLI npm version: 12.0.0-alpha.3 Took changelog and testplan from facebook/react-native#36793 ## Changelog: [General][Fixed] - Bump CLI to 12.0.0-alpha.3 and Metro to 0.76.2 Pull Request resolved: facebook/react-native#36948 Test Plan: CircleCI Reviewed By: huntie Differential Revision: D45081058 Pulled By: jacdebug fbshipit-source-id: 4c7b1004668ac30045577da54311bcab1a905ca9 Original: facebook/react-native@25709af
blakef
pushed a commit
to react-native-community/template
that referenced
this pull request
Feb 29, 2024
Summary: This is follow up of Metro release 0.76.2 to Bump versions in RN. Metro version: 0.76.2 Metro release notes: https://github.com/facebook/metro/releases/tag/v0.76.2 CLI Bump PR: react-native-community/cli#1910 CLI npm version: 12.0.0-alpha.3 Took changelog and testplan from facebook/react-native#36793 ## Changelog: [General][Fixed] - Bump CLI to 12.0.0-alpha.3 and Metro to 0.76.2 Pull Request resolved: facebook/react-native#36948 Test Plan: CircleCI Reviewed By: huntie Differential Revision: D45081058 Pulled By: jacdebug fbshipit-source-id: 4c7b1004668ac30045577da54311bcab1a905ca9 Original-Commit: facebook/react-native@25709af
blakef
pushed a commit
to react-native-community/template
that referenced
this pull request
Feb 29, 2024
Summary: This is follow up of Metro release 0.76.2 to Bump versions in RN. Metro version: 0.76.2 Metro release notes: https://github.com/facebook/metro/releases/tag/v0.76.2 CLI Bump PR: react-native-community/cli#1910 CLI npm version: 12.0.0-alpha.3 Took changelog and testplan from facebook/react-native#36793 ## Changelog: [General][Fixed] - Bump CLI to 12.0.0-alpha.3 and Metro to 0.76.2 Pull Request resolved: facebook/react-native#36948 Test Plan: CircleCI Reviewed By: huntie Differential Revision: D45081058 Pulled By: jacdebug fbshipit-source-id: 4c7b1004668ac30045577da54311bcab1a905ca9 Original-Commit: facebook/react-native@25709af
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
@types/metro*
dependencies, since Metro packages now ship with TypeScript definitions. Adjusts some// @ts-ignore
s.Metro release notes: https://github.com/facebook/metro/releases/tag/v0.76.2
Changelog between 0.76.0 (previous version in
cli-plugin-metro
) and 0.76.2: https://github.com/facebook/metro/compare/v0.76.0..v0.76.2Reminder: When React Native updates the CLI to a version that depends on metro 0.76.2, it must also update
metro-runtime
etc to 0.76.2 in the same commit.Test Plan
yarn build
.yarn test
.