breaking: node 16; typescript 4 #1844
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thymikee
commented
Feb 20, 2023
| @@ -11,7 +11,7 @@ | |||
| "@react-native-community/cli-tools": "^10.1.1", | |||
| "chalk": "^4.1.2", | |||
| "cosmiconfig": "^5.1.0", | |||
| "deepmerge": "^3.2.0", | |||
| "deepmerge": "^4.3.0", | |||
There was a problem hiding this comment.
this turned out to be unnecessary, but checking the release notes the only breaking change is umd -> cjs, which is fine for us
thymikee
force-pushed
the
feat/node-16-ts-4
branch
from
957a0f4
to
a510b91
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Started off #1842 by @robhogan. Wanted to bump min Node to 16, turned out we need to upgrade TS to 4 (about time tbh). Hence I moved it to a sperate PR.
Test Plan:
CI