[10.x] chore(deps): Metro to 0.73.8 (Terser source map fixes) #1841
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robhogan
changed the title
Member
0.71.4 is def happening - but it will be blocked until we get a new CLI 10.x with this commit in ;) |
thymikee
approved these changes
Feb 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Metro 0.73.8 addresses two bugs with Metro release bundle source map generation when using the default Terser minifier. This amounts to a regression for users who used the previous
uglify-esdefault.I've proposed including this in a potential RN 0.71.4 release, a prerequisite of that is that we have a 10.x version of RN CLI that includes it.
(It'd be fine to hold off on merging this / a CLI release until RN 0.71.4 is definitely happening)Test Plan:
Versions bumped with Yarn so local changes are all generated. See facebook/metro#928 and facebook/metro#929 for details of testing the Metro changes.