-
Notifications
You must be signed in to change notification settings - Fork 927
feat: build-android command #1739
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: build-android command #1739
Conversation
That's great! A couple of thoughts:
|
} | ||
type AndroidProject = NonNullable<Config['project']['android']>; | ||
|
||
async function buildAndroid( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it make sense to have this function exported or shared, so it could be reused from the run-android
?
Apart from |
Yeah, makes sense :)
@thymikee - from what I gather cli/packages/cli-platform-android/src/commands/runAndroid/tryLaunchAppOnDevice.ts Line 19 in f0f302d
Not sure why we would like to pass it to
@cortinico - so something similar to react-native build-android gradleParams `PnewArchEnabled=true,PreactNativeArchitectures=x86_64` |
16a9ffd
to
7693d60
Compare
packages/cli-platform-android/src/commands/buildAndroid/index.ts
Outdated
Show resolved
Hide resolved
packages/cli-platform-android/src/commands/buildAndroid/index.ts
Outdated
Show resolved
Hide resolved
packages/cli-platform-android/src/commands/buildAndroid/index.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Michał Pierzchała <thymikee@gmail.com>
Co-authored-by: Michał Pierzchała <thymikee@gmail.com>
Co-authored-by: Michał Pierzchała <thymikee@gmail.com>
packages/cli-platform-android/src/commands/buildAndroid/index.ts
Outdated
Show resolved
Hide resolved
packages/cli-platform-android/src/commands/buildAndroid/index.ts
Outdated
Show resolved
Hide resolved
Yes that would work (maybe
|
6e85013
to
8259f8b
Compare
@cortinico tested with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome 👍 LGTM
packages/cli-platform-android/src/commands/buildAndroid/index.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One more thing and it's good from my side
packages/cli-platform-android/src/commands/buildAndroid/index.ts
Outdated
Show resolved
Hide resolved
b5dacb5
to
1a7272f
Compare
Summary:
build-android
command that will create android build without starting packager and launching emulator.Fixes #1128
Fixes #1150
Part of #179 (together with #1744 )
Closes #1055
Test Plan:
Clone the fork and run
build-android
command with desired options.react-native build-android
react-native build-android --mode release
react-native build-android --tasks 'assembleDebug'
react-native build-android --mode 'release' --tasks 'assembleDebug'
(should issue a warning in terminal)react-native build-android --extra-params "--configure-on-demand -x lint -x test --scan --info"