Skip to content

fix(platform-android): findComponentDescriptors picks up directories #1614

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 20, 2022
Merged

fix(platform-android): findComponentDescriptors picks up directories #1614

merged 2 commits into from
May 20, 2022

Conversation

tido64
Copy link
Contributor

@tido64 tido64 commented May 20, 2022

Summary:

findComponentDescriptors may pick up directories, e.g. decimal.js, and throw when trying to read it.

Test Plan:

Add decimal.js as a dependency and run react-native config

thymikee
thymikee approved these changes May 20, 2022
View reviewed changes
Copy link
Member

@thymikee thymikee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds reasonable, thanks!

@thymikee thymikee merged commit e9e89eb into react-native-community:master May 20, 2022
@tido64 tido64 deleted the tido/fix-find-descriptors branch May 20, 2022 13:51
@tido64 tido64 mentioned this pull request May 31, 2022
Closed
34 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thymikee thymikee thymikee approved these changes

@grabbou grabbou Awaiting requested review from grabbou

@Esemesek Esemesek Awaiting requested review from Esemesek

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tido64 @thymikee