-
Notifications
You must be signed in to change notification settings - Fork 906
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(breaking): remove deprecated link
, unlink
and associated code
#1537
Merged
Merged
Changes from 1 commit
Commits
Show all changes
40 commits
Select commit
Hold shift + click to select a range
e151563
chore: initial commit - remove files
grabbou 0ae9eea
chore: further removal
grabbou 30103d3
chore: wip
grabbou 6c53e48
continue work
grabbou 596d849
chore: fix warnings and errors
grabbou 8a24cd2
chore: move findXcodeProj to config and upgrade run-ios
grabbou a1fe895
chore: add todo
grabbou 2f8baf8
chore: remove example
grabbou 510a903
chore: update source dir and update dependnecy config for ios
grabbou 2a43345
chore: remove logger
grabbou 410ec1a
chore: fix type issues
grabbou b3e0730
chore: remove tests for missing properties, prefer snapshots instead …
grabbou 16996b3
chore: update snapshots for iOS config (removed properties)
grabbou a67a5a6
chore: fix upgrade tests
grabbou 65f4335
chore: remove extra tests
grabbou edf3175
chore: update config tests
grabbou 3854ee3
chore: two tests tbd to support new resolution mechanism
grabbou f8a9ade
chore: fix ios tests and bring back configurable sourceDir
grabbou 1c9508e
feat: align findPodfilePath with old findProject heuristics
grabbou be963e1
chore: fix lint
grabbou 194ee75
chore: update snapshot
grabbou 387f9ee
fix: filter invalid deps
grabbou 299285f
chore: update tests
grabbou d665720
chore: add missing properties to Joi schema
grabbou 020aa16
chore: another update
grabbou 0153690
chore: fix Joi schema
grabbou f8fd19d
chore: update schema
grabbou de1a5d2
chore: fix snapshot
grabbou 2c732a8
chore: note on the future development for this file
grabbou 6051201
chore: update snapshot one more time - nitpick
grabbou 361f0c9
one last time
grabbou 64b4ef7
feat: print when multiple podfiles are found
grabbou 00ccd36
update docs
grabbou 59cb6e0
chore: fix
grabbou 9e70eb3
Update autolinking.md
grabbou 48686a9
chore: remove xmldoc dep
thymikee 7326892
chore: remove xcode dep
thymikee 794d9b3
chore: return type for dependencyConfig
thymikee ae7c66e
Merge branch 'master' into feat/remove-link
grabbou 3e5cb0b
Update index.ts
grabbou File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
feat: align findPodfilePath with old findProject heuristics
- Loading branch information
commit 1c9508e62a34ad316919612928e26642379ce171
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I ran this locally and got:
I think printing a warning can be very helpful, but there can be false positives if you also have a macOS project. Maybe we could print the list if
--verbose
is specified?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this idea.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We will favour
iOS
anyway since this isiOSConfig
used forrun-ios
. But I guess we can adapt it in a later PR to work forMac
too?Can you point me to a configuration/helpers that you use for
macos
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
findXcodeProject
is here: https://github.com/microsoft/react-native-macos/blob/main/local-cli/runMacOS/findXcodeProject.jsIt only gets called from
run-macos
(code), so it can assume thatpod install
has happened. You wouldn't be able to use it forconfig
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
BTW, do you want me to export you this helper so you can reduce some code overlap? Or prefer to keep it internal?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@HeyImChris I believe we search for podfiles rather than Xcode projects to support scenarios like react-native-test-app, which generates an xcode project given a podfile. In effect, the source of truth becomes the podfile and not the xcode project. I remember when @tido64 pushed for this change in the CLI which in turn helped us use react-native-test-app for FluentUI React Native.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Saadnajmi there's a sub-package
@react-native-community/platform-ios
. React Native depends on it. CLI doesn't. CLI detects runtime packages with platforms (such asplatform-ios
, orreact-native-windows
) and adds commands / configurations based on installed packages.So by depending on
platform-ios
, you wouldn't pull the entire CLI.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this change makes sense given that we wouldn't be taking on a bunch of new dependencies with the obvious value of reducing our diffs. @Saadnajmi sound good to you?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As it turns out, we already have a dependency on the CLI (thanks @HeyImChris for pointing it out) so yeah this would be great! Yay code sharing!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right -> https://github.com/microsoft/react-native-macos/blob/26a7c3e9d430ebb58b9c9e2aa220fe9019ae1e1f/package.json#L99.
I will open a follow-up issue to explore various code-sharing opportunities.