Skip to content

yarn watch doesn't get changes from all files on Linux and Windows #989

Closed
@molant

Description

@molant

Environment

Linux:

System:
    OS: Linux 4.19 Ubuntu 18.04.4 LTS (Bionic Beaver)
    CPU: (8) x64 Intel(R) Core(TM) i7-1065G7 CPU @ 1.30GHz
    Memory: 10.65 GB / 12.17 GB
    Shell: 4.4.20 - /bin/bash
  Binaries:
    Node: 12.16.0 - ~/.nvm/versions/node/v12.16.0/bin/node
    Yarn: 1.21.1 - /usr/bin/yarn
    npm: 6.13.4 - ~/.nvm/versions/node/v12.16.0/bin/npm

Windows:

System:
    OS: Windows 10
    CPU: (8) x64 Intel(R) Core(TM) i7-1065G7 CPU @ 1.30GHz
    Memory: 5.42 GB / 15.60 GB
  Binaries:
    Node: 12.16.0 - C:\Program Files\nodejs\node.EXE
    Yarn: 1.22.0 - C:\Program Files (x86)\Yarn\bin\yarn.CMD
    npm: 6.13.4 - C:\Program Files\nodejs\npm.CMD

Description

Trying to work on the CLI project. Running yarn watch doesn't detect changes in all files.
The ones under packages/cli/src are detected, but if I change something in a file nested more deeply it doesn't work (e.g.: packages/cli/src/commands/doctor/info.ts).

Reproducible Demo

I've attached a gif of the issue. It's a bit blurry but hopefully you can see what's going on:

watch-issue

  1. Change to packages/cli/src/bin.ts gets detected
  2. Change to packages/cli/commands/doctor/info.ts goes unnoticed

This happens in Linux and Windows just after cloning and doing yarn with node 12 and 13. It looks like the code to watch should work (recursive: true). Don't know if it is a node limitation in these platforms (ie.: limit on ionodes on Linux) or if it happens on macOS as well.
Happy to work on this although I might have to pull an extra package to make it work cross platform.

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions