refactor: enable recommendedTypeChecked rules
#1107
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
8 tasks
marcalexiei
force-pushed
the
ts-eslint-strict
branch
from
95a9148 to
5353f16
Compare
marcalexiei
force-pushed
the
ts-eslint-strict
branch
from
5353f16 to
b1e10c9
Compare
marcalexiei
force-pushed
the
ts-eslint-strict
branch
from
b1e10c9 to
57e8442
Compare
bluebill1049
approved these changes
Jan 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Last part of #1098
recommendedtypescript-eslintconfig withrecommendedTypeCheckedcontentlayer.config.ts→ I tried to refine generated types but there are some upstream issues.I added a few comments with relevant information
src/components/CodeCompareSection.tsx→ removed ternaries since the whole block is already wrapped in an if that checkisPlayCodeCompare"truthiness" (line 40)src/components/mdx/code.tsx→ Simplified theme logic with auseMemosrc/components/mdx/youtube.tsx→ RemovedyouTubePlaylistId,aspectRatioandskipToprops since they were not used.Warning
Like happened in #1103 now also
lintrequires content layer so we have to build the project before running the lint task.A new
lint:ciscript has been added alongside nextConfigeslint.ignoreDuringBuildsflag.