fix: add mergedData length check #306

hakankosdag · 2025-02-28T02:51:48Z

Problem

When mergedData updates rapidly, an issue occurs in rc-virtual-list where the component behaves unexpectedly due to missing length validation.

reproduce link: https://codepen.io/hk-s/pen/dPyOxKx?editors=0011

Solution

Added a length check for mergedData in the if condition to prevent this issue.

Summary by CodeRabbit

更新后的发布说明

Bug Fixes
- 调整了列表视图的滚动逻辑，现在仅在存在可显示数据时才进行滚动调整，从而避免了无数据时出现的不必要滚动行为。

vercel · 2025-02-28T02:51:53Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
virtual-list	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Feb 28, 2025 6:36am

coderabbitai · 2025-02-28T02:51:56Z

Walkthrough

这次变更调整了 src/List.tsx 文件中 RawList 函数内的 useLayoutEffect 钩子。原先直接访问 mergedData[start] 来获取 startIndexKey，假设 start 索引总是有效。更新后的实现增加了对 startItem 是否定义的检查，确保只有在有有效项时才执行滚动调整逻辑，避免了潜在的越界错误。

Changes

文件路径	变更摘要
`src/List.tsx`	修改 `useLayoutEffect` 内的逻辑，新增对 `startItem` 的检查，确保在有效项存在时才执行滚动调整。

Sequence Diagram(s)

sequenceDiagram
    participant R as RawList 函数
    participant U as useLayoutEffect 钩子
    participant S as 滚动调整逻辑

    R->>U: 触发布局更新
    U->>U: 检查 startItem 是否定义
    alt 条件满足
        U->>S: 执行滚动调整
    else 条件不满足
        U->>U: 跳过滚动调整
    end

Possibly related PRs

enhance: Scroll top should not shaking #296: 该PR中的更改增强了 RawList 组件中的滚动调整逻辑，与本PR中对 useLayoutEffect 钩子的修改相关。

Poem

我是一只编码小兔，
在代码森林里悠然奔走，
新增条件迎着晨曦闪烁，
有效项在手才调整节奏，
每次变更都充满奇妙韵律。
🐇🌸🐾

Warning

There were issues while running some tools. Please review the errors and either fix the tool’s configuration or disable the tool if it’s a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

src/List.tsx

Oops! Something went wrong! :(

ESLint: 8.57.1

Error: Cannot read config file: /.eslintrc.js
Error: Cannot find module '@umijs/fabric/dist/eslint'
Require stack:

/.eslintrc.js
/node_modules/.pnpm/@eslint+eslintrc@2.1.4/node_modules/@eslint/eslintrc/dist/eslintrc.cjs
/node_modules/.pnpm/eslint@8.57.1/node_modules/eslint/lib/cli-engine/cli-engine.js
/node_modules/.pnpm/eslint@8.57.1/node_modules/eslint/lib/eslint/eslint.js
/node_modules/.pnpm/eslint@8.57.1/node_modules/eslint/lib/eslint/index.js
/node_modules/.pnpm/eslint@8.57.1/node_modules/eslint/lib/cli.js
/node_modules/.pnpm/eslint@8.57.1/node_modules/eslint/bin/eslint.js
at Module._resolveFilename (node:internal/modules/cjs/loader:1248:15)
at Module._load (node:internal/modules/cjs/loader:1074:27)
at TracingChannel.traceSync (node:diagnostics_channel:315:14)
at wrapModuleLoad (node:internal/modules/cjs/loader:217:24)
at Module.require (node:internal/modules/cjs/loader:1339:12)
at require (node:internal/modules/helpers:135:16)
at Object. (/.eslintrc.js:1:14)
at Module._compile (node:internal/modules/cjs/loader:1546:14)
at Module._extensions..js (node:internal/modules/cjs/loader:1691:10)
at Module.load (node:internal/modules/cjs/loader:1317:32)

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 2f78a02 and eb4f6e5.

📒 Files selected for processing (1)

src/List.tsx (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

src/List.tsx

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

yoyo837 · 2025-02-28T03:08:56Z

Could you make a reproduction link of this problem first?

hakankosdag · 2025-02-28T04:14:54Z

Could you make a reproduction link of this problem first?

If you type 0-321 in order in the search field you can reproduce the error.

https://codepen.io/hk-s/pen/dPyOxKx?editors=0011

codecov · 2025-02-28T06:37:55Z

Codecov Report

Attention: Patch coverage is 0% with 8 lines in your changes missing coverage. Please review.

Project coverage is 97.27%. Comparing base (66e8450) to head (eb4f6e5).
Report is 1 commits behind head on master.

Files with missing lines	Patch %	Lines
src/List.tsx	0.00%	8 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #306      +/-   ##
==========================================
- Coverage   97.51%   97.27%   -0.25%     
==========================================
  Files          19       19              
  Lines         806      808       +2     
  Branches      194      195       +1     
==========================================
  Hits          786      786              
- Misses         20       22       +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

zombieJ · 2025-02-28T06:41:37Z

+ rc-virtual-list@3.18.3

fix: add mergedData length check

2f78a02

vercel bot deployed to Preview February 28, 2025 02:52 View deployment

zombieJ self-assigned this Feb 28, 2025

chore: check first

eb4f6e5

vercel bot deployed to Preview February 28, 2025 06:36 View deployment

zombieJ merged commit d939a83 into react-component:master Feb 28, 2025
9 of 11 checks passed

coderabbitai bot mentioned this pull request May 6, 2025

fix: Dynamic height bump the scroll pos in some edge case #309

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix: add mergedData length check #306

fix: add mergedData length check #306

Uh oh!

hakankosdag commented Feb 28, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

vercel bot commented Feb 28, 2025 •

edited

Loading

Uh oh!

coderabbitai bot commented Feb 28, 2025 •

edited

Loading

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

yoyo837 commented Feb 28, 2025

Uh oh!

hakankosdag commented Feb 28, 2025

Uh oh!

codecov bot commented Feb 28, 2025 •

edited

Loading

Uh oh!

Uh oh!

zombieJ commented Feb 28, 2025

Uh oh!

Uh oh!

fix: add mergedData length check #306

fix: add mergedData length check #306

Uh oh!

Conversation

hakankosdag commented Feb 28, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Problem

Solution

Summary by CodeRabbit

更新后的发布说明

Uh oh!

vercel bot commented Feb 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai bot commented Feb 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Sequence Diagram(s)

Possibly related PRs

Poem

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

yoyo837 commented Feb 28, 2025

Uh oh!

hakankosdag commented Feb 28, 2025

Uh oh!

codecov bot commented Feb 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

zombieJ commented Feb 28, 2025

Uh oh!

Uh oh!

hakankosdag commented Feb 28, 2025 •

edited by coderabbitai bot

Loading

vercel bot commented Feb 28, 2025 •

edited

Loading

coderabbitai bot commented Feb 28, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

codecov bot commented Feb 28, 2025 •

edited

Loading