fix: Skip scroll when draggable #304

zombieJ · 2025-02-14T08:21:29Z

Summary by CodeRabbit

Bug Fixes
- 优化了拖拽交互体验，确保当操作允许拖拽的项目时不会触发额外的滚动，从而提供更顺畅、稳定的用户操作反馈。

vercel · 2025-02-14T08:21:31Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
virtual-list	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Feb 14, 2025 8:22am

coderabbitai · 2025-02-14T08:21:37Z

Walkthrough

该 PR 对 useScrollDrag 钩子的 onMouseDown 事件处理逻辑进行了修改，加入了对目标元素是否可拖动的判断。如果目标被标记为可拖动，则提前返回，不继续处理拖动逻辑。同时，测试文件 tests/scroll.test.js 中新增了测试套件，对拖动行为进行了更清晰的组织，更新了部分函数签名，并增加了检测拖动后滚动位置变化以及在项目可拖动时滚动位置保持不变的测试案例。

Changes

文件路径	变更摘要
`src/hooks/useScrollDrag.ts`	在 `onMouseDown` 中增加判断：若目标元素可拖动则提前返回处理。
`tests/scroll.test.js`	新增测试套件；更新 `dragDown` 与 `getScrollTop` 函数签名；新增测试用例验证拖动行为与滚动位置变化。

Sequence Diagram(s)

sequenceDiagram
    participant U as 用户
    participant S as useScrollDrag
    U->>S: 触发 onMouseDown 事件
    alt 目标元素可拖动
        S-->>U: 提前退出处理
    else 目标元素不可拖动
        S->>S: 执行拖动逻辑
        S-->>U: 完成事件处理
    end

sequenceDiagram
    participant T as 测试用例
    participant L as List组件
    T->>L: 模拟拖动行为 (mouse down, move)
    alt 项目未标记为可拖动
        L-->>T: 滚动位置增加或重置
    else 项目标记为可拖动
        L-->>T: 滚动位置保持不变
    end

Possibly related PRs

feat: mouse down to scroll #293: 修改 onMouseDown 事件处理逻辑，与当前 PR 对拖动逻辑的增强存在直接代码层面的联系。
enhance: Scroll top should not shaking #296: 添加了关于拖拽时元素标记为可拖动的测试用例，与本 PR 中测试增强内容直接相关。
fix: scroll offset should not block #294: 对 useScrollDrag 文件中鼠标事件处理进行了调整，与本次对 onMouseDown 判断逻辑的修改密切相关。

Suggested reviewers

MadCcc

Poem

我是一只欢快的小兔子，
在代码丛林中跳跃不停，
拖动逻辑如今更聪明，
测试验证步步为营，
程序世界变得更精致，
像跳跃的小兔般快乐不断！ 🐰✨

Warning

There were issues while running some tools. Please review the errors and either fix the tool’s configuration or disable the tool if it’s a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

src/hooks/useScrollDrag.ts

Oops! Something went wrong! :(

ESLint: 8.57.1

Error: Cannot read config file: /.eslintrc.js
Error: Cannot find module '@umijs/fabric/dist/eslint'
Require stack:

/.eslintrc.js
/node_modules/.pnpm/@eslint+eslintrc@2.1.4/node_modules/@eslint/eslintrc/dist/eslintrc.cjs
/node_modules/.pnpm/eslint@8.57.1/node_modules/eslint/lib/cli-engine/cli-engine.js
/node_modules/.pnpm/eslint@8.57.1/node_modules/eslint/lib/eslint/eslint.js
/node_modules/.pnpm/eslint@8.57.1/node_modules/eslint/lib/eslint/index.js
/node_modules/.pnpm/eslint@8.57.1/node_modules/eslint/lib/cli.js
/node_modules/.pnpm/eslint@8.57.1/node_modules/eslint/bin/eslint.js
at Module._resolveFilename (node:internal/modules/cjs/loader:1248:15)
at Module._load (node:internal/modules/cjs/loader:1074:27)
at TracingChannel.traceSync (node:diagnostics_channel:315:14)
at wrapModuleLoad (node:internal/modules/cjs/loader:217:24)
at Module.require (node:internal/modules/cjs/loader:1339:12)
at require (node:internal/modules/helpers:135:16)
at Object. (/.eslintrc.js:1:14)
at Module._compile (node:internal/modules/cjs/loader:1546:14)
at Module._extensions..js (node:internal/modules/cjs/loader:1691:10)
at Module.load (node:internal/modules/cjs/loader:1317:32)

tests/scroll.test.js

Oops! Something went wrong! :(

ESLint: 8.57.1

Error: Cannot read config file: /.eslintrc.js
Error: Cannot find module '@umijs/fabric/dist/eslint'
Require stack:

/.eslintrc.js
/node_modules/.pnpm/@eslint+eslintrc@2.1.4/node_modules/@eslint/eslintrc/dist/eslintrc.cjs
/node_modules/.pnpm/eslint@8.57.1/node_modules/eslint/lib/cli-engine/cli-engine.js
/node_modules/.pnpm/eslint@8.57.1/node_modules/eslint/lib/eslint/eslint.js
/node_modules/.pnpm/eslint@8.57.1/node_modules/eslint/lib/eslint/index.js
/node_modules/.pnpm/eslint@8.57.1/node_modules/eslint/lib/cli.js
/node_modules/.pnpm/eslint@8.57.1/node_modules/eslint/bin/eslint.js
at Module._resolveFilename (node:internal/modules/cjs/loader:1248:15)
at Module._load (node:internal/modules/cjs/loader:1074:27)
at TracingChannel.traceSync (node:diagnostics_channel:315:14)
at wrapModuleLoad (node:internal/modules/cjs/loader:217:24)
at Module.require (node:internal/modules/cjs/loader:1339:12)
at require (node:internal/modules/helpers:135:16)
at Object. (/.eslintrc.js:1:14)
at Module._compile (node:internal/modules/cjs/loader:1546:14)
at Module._extensions..js (node:internal/modules/cjs/loader:1691:10)
at Module.load (node:internal/modules/cjs/loader:1317:32)

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 82566ea and ecd3b2c.

📒 Files selected for processing (2)

src/hooks/useScrollDrag.ts (1 hunks)
tests/scroll.test.js (2 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (1)

GitHub Check: Analyze (javascript)

🔇 Additional comments (4)

src/hooks/useScrollDrag.ts (1)

42-45: 代码变更看起来不错！

新增的可拖动元素检查可以有效防止与原生拖放功能发生冲突。这种实现方式简洁明了,并且保持了良好的关注点分离。

tests/scroll.test.js (3)

580-598: 测试辅助函数改进得很好！

函数参数化设计提高了代码的复用性，同时保持了功能的准确性。

600-622: 测试用例设计合理！

该测试用例很好地覆盖了向上和向下滚动的场景，并通过适当的断言验证了滚动位置的变化。使用模拟定时器处理动画也是一个很好的做法。

624-645: 测试覆盖了关键功能！

这个测试用例很好地验证了可拖动项目的行为，确保了滚动位置在拖动操作期间保持不变。测试结构清晰，断言完整。

✨ Finishing Touches

📝 Generate Docstrings (Beta)

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

codecov · 2025-02-14T08:22:07Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.51%. Comparing base (82566ea) to head (ecd3b2c).
Report is 1 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff           @@
##           master     #304   +/-   ##
=======================================
  Coverage   97.51%   97.51%           
=======================================
  Files          19       19           
  Lines         804      806    +2     
  Branches      193      194    +1     
=======================================
+ Hits          784      786    +2     
  Misses         20       20

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

zombieJ added 3 commits February 14, 2025 16:06

fix: draggable

78ddcf3

test: add test case

12f420d

chore: translate

ecd3b2c

vercel bot deployed to Preview February 14, 2025 08:22 View deployment

zombieJ merged commit 818f9de into master Feb 14, 2025
12 checks passed

zombieJ deleted the fix-draggable branch February 14, 2025 08:23

coderabbitai bot mentioned this pull request Mar 20, 2025

fix: right click should not trigger drag #307

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix: Skip scroll when draggable #304

fix: Skip scroll when draggable #304

Uh oh!

zombieJ commented Feb 14, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

vercel bot commented Feb 14, 2025 •

edited

Loading

Uh oh!

coderabbitai bot commented Feb 14, 2025 •

edited

Loading

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

codecov bot commented Feb 14, 2025 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

fix: Skip scroll when draggable #304

fix: Skip scroll when draggable #304

Uh oh!

Conversation

zombieJ commented Feb 14, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

vercel bot commented Feb 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai bot commented Feb 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Sequence Diagram(s)

Possibly related PRs

Suggested reviewers

Poem

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

codecov bot commented Feb 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Uh oh!

zombieJ commented Feb 14, 2025 •

edited by coderabbitai bot

Loading

vercel bot commented Feb 14, 2025 •

edited

Loading

coderabbitai bot commented Feb 14, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

codecov bot commented Feb 14, 2025 •

edited

Loading