-
-
Notifications
You must be signed in to change notification settings - Fork 233
fix: fix popup glitch when there is not enough width #548
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Caution Review failedThe pull request is closed. Walkthrough本次更改调整了在 Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant useAlign Hook
participant Popup Element
User->>useAlign Hook: 触发对齐逻辑
useAlign Hook->>Popup Element: 获取 position(computed style)
useAlign Hook->>Popup Element: 获取 boundingClientRect
useAlign Hook->>Popup Element: 获取 width, height(computed style)
useAlign Hook-->>User: 完成对齐处理
Assessment against linked issues
Assessment against linked issues: Out-of-scope changes(未发现超出关联 issue 目标的更改。) Possibly related PRs
Suggested reviewers
Poem
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ESLint
src/hooks/useAlign.tsOops! Something went wrong! :( ESLint: 8.57.1 ESLint couldn't find the plugin "eslint-plugin-react". (The package "eslint-plugin-react" was not found when loaded as a Node module from the directory "".) It's likely that the plugin isn't installed correctly. Try reinstalling by running the following:
The plugin "eslint-plugin-react" was referenced from the config file in ".eslintrc.js » /node_modules/.pnpm/@umijs+fabric@4.0.1_postcss@8.5.6/node_modules/@umijs/fabric/dist/eslint.js". If you still can't figure out the problem, please stop by https://eslint.org/chat/help to chat with the team. 📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
✨ Finishing Touches
🧪 Generate Unit Tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #548 +/- ##
=======================================
Coverage 97.75% 97.75%
=======================================
Files 13 13
Lines 800 801 +1
Branches 235 239 +4
=======================================
+ Hits 782 783 +1
Misses 18 18 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Cherry-pick from #510
fix #496 for
antd@5
Summary by CodeRabbit