Skip to content

Use virtual list #197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 52 commits into from
Sep 26, 2019
Merged

Use virtual list #197

merged 52 commits into from
Sep 26, 2019

Conversation

zombieJ
Copy link
Member

@zombieJ zombieJ commented Sep 24, 2019

@codecov
Copy link

codecov bot commented Sep 25, 2019

Codecov Report

Merging #197 into master will increase coverage by 2.16%.
The diff coverage is 99.8%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #197      +/-   ##
=========================================
+ Coverage   97.63%   99.8%   +2.16%     
=========================================
  Files          16      11       -5     
  Lines         931     514     -417     
  Branches      219     150      -69     
=========================================
- Hits          909     513     -396     
+ Misses         20       1      -19     
+ Partials        2       0       -2
Impacted Files Coverage Δ
src/utils/warningPropsUtil.ts 100% <100%> (ø)
src/hooks/useKeyValueMap.ts 100% <100%> (ø)
src/hooks/useSelectValues.ts 100% <100%> (ø)
src/utils/strategyUtil.ts 100% <100%> (ø)
src/utils/legacyUtil.tsx 100% <100%> (ø)
src/hooks/useKeyValueMapping.ts 100% <100%> (ø)
src/Context.tsx 100% <100%> (ø)
src/TreeSelect.tsx 100% <100%> (ø)
src/hooks/useTreeData.ts 100% <100%> (ø)
src/utils/valueUtil.ts 100% <100%> (ø)
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fe33eb7...1edf993. Read the comment docs.

@vercel vercel bot temporarily deployed to staging September 26, 2019 11:44 Inactive
@zombieJ zombieJ marked this pull request as ready for review September 26, 2019 12:34
@zombieJ zombieJ merged commit 7f7208f into master Sep 26, 2019
@delete-merged-branch delete-merged-branch bot deleted the virtual branch September 26, 2019 12:39
@yoyo837
Copy link
Member

yoyo837 commented Sep 27, 2019

Can this fix ant-design/ant-design/issues/18863?

@zombieJ
Copy link
Member Author

zombieJ commented Sep 29, 2019

ant-design/ant-design/issues/18863 is not a bug, it's usage issue. Should user handle check logic self.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants