Skip to content

Fixed the scrolling issue occurring in mobile #431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Fixed the scrolling issue occurring in mobile #431

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions src/hooks/useTouchMove.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,6 @@ export default function useTouchMove(

function onTouchMove(e: TouchEvent) {
if (!touchPosition) return;

e.preventDefault();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should prevent by move direct instead. Not remove directly

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should prevent by move direct instead. Not remove directly

What “prevent by move direct ” means?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For horizontal preventDefault with up & down but not block with left & right. And vertical is prevent up & down but not left & right.

Copy link

@Chorer Chorer Dec 21, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For horizontal preventDefault with up & down but not block with left & right. And vertical is prevent up & down but not left & right.

It seems @pplcallmesatz didn't make some new commits. Why can't you just fix the bug?

const { screenX, screenY } = e.touches[0];
setTouchPosition({ x: screenX, y: screenY });
const offsetX = screenX - touchPosition.x;
Expand Down