Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: rerender table trigger table-body collapses #1016

Merged
merged 1 commit into from
Aug 30, 2023

Conversation

bbb169
Copy link
Contributor

@bbb169 bbb169 commented Aug 30, 2023

When a table has 'scrollX' prop is initialized , the height of the table body collapses to zero. This issue leads to shaking when two tables are switched. The root cause is the presence of empty text in ExpandedRow. To address this, introduce a conditional check for horizonScroll to prevent this unintended behavior.

issue: ant-design/ant-design#44281

@vercel
Copy link

vercel bot commented Aug 30, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
table ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 30, 2023 0:20am

@codecov
Copy link

codecov bot commented Aug 30, 2023

Codecov Report

Merging #1016 (dfd5fe3) into master (6f538dc) will decrease coverage by 0.24%.
Report is 5 commits behind head on master.
The diff coverage is 98.60%.

❗ Current head dfd5fe3 differs from pull request most recent head b69a7cd. Consider uploading reports for the commit b69a7cd to get more accurate results

@@            Coverage Diff             @@
##           master    #1016      +/-   ##
==========================================
- Coverage   99.52%   99.29%   -0.24%     
==========================================
  Files          40       47       +7     
  Lines        3562     4369     +807     
  Branches      477      550      +73     
==========================================
+ Hits         3545     4338     +793     
- Misses         17       31      +14     
Files Changed Coverage Δ
src/hooks/useColumns/useWidthColumns.tsx 91.04% <91.04%> (ø)
src/VirtualTable/BodyGrid.tsx 96.62% <96.62%> (ø)
src/Body/BodyRow.tsx 100.00% <100.00%> (ø)
src/Body/ExpandedRow.tsx 100.00% <100.00%> (ø)
src/Body/index.tsx 100.00% <100.00%> (ø)
src/Cell/index.tsx 100.00% <100.00%> (ø)
src/Cell/useCellRender.ts 100.00% <100.00%> (ø)
src/Footer/index.tsx 100.00% <100.00%> (ø)
src/Header/Header.tsx 100.00% <100.00%> (ø)
src/Table.tsx 99.76% <100.00%> (+<0.01%) ⬆️
... and 10 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@afc163 afc163 merged commit 719d285 into react-component:master Aug 30, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants