Skip to content

Conversation

@DBSDs
Copy link
Contributor

@DBSDs DBSDs commented Nov 11, 2022

  1. 'CustomTagProps' is removed in '../src/interface/generator';
  2. '<OptionList ref={ref} />' ref:any can't distribute to ref:never

@vercel
Copy link

vercel bot commented Nov 11, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
select ❌ Failed (Inspect) Nov 19, 2022 at 0:36AM (UTC)

@DBSDs
Copy link
Contributor Author

DBSDs commented Nov 12, 2022

(test failed)i think it's rc-test's error.rc-test"enzyme-adapter-react-16": "^1.15.6" is moved from dependencies to devDependencies

@afc163
Copy link
Member

afc163 commented Nov 14, 2022

Please rebase master.

@DBSDs
Copy link
Contributor Author

DBSDs commented Nov 14, 2022

Please rebase master.

sorry for my graphical git tools💔

@codecov
Copy link

codecov bot commented Nov 14, 2022

Codecov Report

Merging #862 (bf59b74) into master (8f91ed3) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #862   +/-   ##
=======================================
  Coverage   99.62%   99.62%           
=======================================
  Files          37       37           
  Lines        1337     1337           
  Branches      355      355           
=======================================
  Hits         1332     1332           
  Misses          4        4           
  Partials        1        1           
Impacted Files Coverage Δ
src/OptionList.tsx 99.30% <100.00%> (ø)
src/utils/valueUtil.ts 100.00% <100.00%> (ø)
src/Select.tsx 100.00% <0.00%> (ø)
src/BaseSelect.tsx 100.00% <0.00%> (ø)
src/Selector/index.tsx 100.00% <0.00%> (ø)
src/Selector/MultipleSelector.tsx 100.00% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@afc163
Copy link
Member

afc163 commented Nov 19, 2022

我看 master 的 ci 已经过了,我们还需要这个 PR 么?

@DBSDs
Copy link
Contributor Author

DBSDs commented Nov 19, 2022

我看 master 的 ci 已经过了,我们还需要这个 PR 么?

应该是需要的,这个pr是针对rc-select项目npm run tsc报错。不过github ci里没有npm run tsc的检查

@afc163
Copy link
Member

afc163 commented Nov 19, 2022

不过github ci里没有npm run tsc的检查

可以加上试试

@DBSDs
Copy link
Contributor Author

DBSDs commented Nov 21, 2022

可以加上试试

模仿ant-design,将npm run tsc 添加到npm lint步骤上,不过vercel deployment failed,我不知道是什么情况

@afc163
Copy link
Member

afc163 commented Nov 21, 2022

我意思是单独发一个 PR 加上 npm run tsc,我看看 master 是否确实报错了。

@DBSDs
Copy link
Contributor Author

DBSDs commented Nov 21, 2022

单独发一个PR我想过,不过pr中还是需要修复tsc报错的commit,否则ci会报错。

@afc163 afc163 merged commit 5f03e16 into react-component:master Nov 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants