-
-
Notifications
You must be signed in to change notification settings - Fork 489
fix: tsc --noEmit error #862
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
(test failed)i think it's rc-test's error. |
|
Please rebase master. |
sorry for my graphical git tools💔 |
Codecov Report
@@ Coverage Diff @@
## master #862 +/- ##
=======================================
Coverage 99.62% 99.62%
=======================================
Files 37 37
Lines 1337 1337
Branches 355 355
=======================================
Hits 1332 1332
Misses 4 4
Partials 1 1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
我看 master 的 ci 已经过了,我们还需要这个 PR 么? |
应该是需要的,这个pr是针对rc-select项目npm run tsc报错。不过github ci里没有 |
可以加上试试 |
模仿ant-design,将npm run tsc 添加到npm lint步骤上,不过vercel deployment failed,我不知道是什么情况 |
|
我意思是单独发一个 PR 加上 npm run tsc,我看看 master 是否确实报错了。 |
|
单独发一个PR我想过,不过pr中还是需要修复tsc报错的commit,否则ci会报错。 |
Uh oh!
There was an error while loading. Please reload this page.