Skip to content

Fix for tabIndex prop handling #572

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Dec 5, 2020
Merged

Fix for tabIndex prop handling #572

merged 4 commits into from
Dec 5, 2020

Conversation

morellodev
Copy link
Contributor

This PR fixes #570

morellodev and others added 2 commits November 25, 2020 12:27
@vercel
Copy link

vercel bot commented Nov 25, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/react-component/select/qfnp2bmmd
✅ Preview: https://select-git-fix-tabindex-prop.react-component.now.sh

@codecov
Copy link

codecov bot commented Nov 25, 2020

Codecov Report

Merging #572 (c79f5e5) into master (7781194) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #572   +/-   ##
=======================================
  Coverage   99.27%   99.27%           
=======================================
  Files          20       20           
  Lines         967      967           
  Branches      327      327           
=======================================
  Hits          960      960           
  Misses          6        6           
  Partials        1        1           
Impacted Files Coverage Δ
src/generate.tsx 99.67% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7781194...c79f5e5. Read the comment docs.

@afc163 afc163 merged commit f984767 into react-component:master Dec 5, 2020
@morellodev morellodev deleted the fix/tabindex-prop branch December 5, 2020 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong handling of the tabIndex prop
2 participants