Skip to content

refactoring: Migrate to new lifecycle methods, close #288 #291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yutingzhao1991 merged 5 commits into from
May 3, 2018
Merged

refactoring: Migrate to new lifecycle methods, close #288 #291

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
6666b41
update to use new react lifecycle
yutingzhao1991 Apr 20, 2018
516832a
fix eslint issue and unittest issue
yutingzhao1991 Apr 20, 2018
a2a73ee
some performance optimization
yutingzhao1991 Apr 20, 2018
77b1c43
merge master
yutingzhao1991 May 3, 2018
34f49c6
fix review issue
yutingzhao1991 May 3, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion examples/multiple.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,6 @@ class Test extends React.Component {
<input checked={this.state.useAnim} type="checkbox" onChange={this.useAnim} />
</label>
</p>

<div style={{ width: 300 }}>
<Select
value={this.state.value}
Expand Down
1 change: 1 addition & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,7 @@
"rc-menu": "^7.0.2",
"rc-trigger": "^2.2.0",
"rc-util": "^4.0.4",
"react-lifecycles-compat": "^3.0.2",
"warning": "^3.0.0"
},
"pre-commit": [
Expand Down
7 changes: 1 addition & 6 deletions src/DropdownMenu.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,14 +24,10 @@ export default class DropdownMenu extends React.Component {

constructor(props) {
super(props);

this.lastInputValue = props.inputValue;
this.saveMenuRef = saveRef(this, 'menuRef');
}

componentWillMount() {
this.lastInputValue = this.props.inputValue;
}

componentDidMount() {
this.scrollActiveItemToView();
this.lastVisible = this.props.visible;
Expand Down Expand Up @@ -142,7 +138,6 @@ export default class DropdownMenu extends React.Component {
if (inputValue !== this.lastInputValue && (!lastValue || lastValue !== backfillValue)) {
activeKeyProps.activeKey = '';
}

return (
<Menu
ref={this.saveMenuRef}
Expand Down
Loading