fix: trigger thumb animation when selected changed
#31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎊 PR Preview ac11587 has been successfully built and deployed to https://react-component-segmented-preview-pr-31.surge.sh 🕐 Build time: 187.02s
🤖 By surge-preview |
vagusX
force-pushed
the
fix/antd-issue-35170
branch
from
fc12c00 to
43e60c7
Compare
vagusX
changed the title
selected changedselected changed
Codecov Report
@@ Coverage Diff @@
## master #31 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 1 1
Lines 72 84 +12
Branches 13 18 +5
=========================================
+ Hits 72 84 +12
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
vagusX
changed the title
selected changedselected changed
vagusX
commented
Apr 22, 2022
| (typeof selected === 'string' || typeof selected === 'number') && | ||
| selected !== latestVisualSelected.current | ||
| ) { | ||
| doThumbAnimation(selected); |
There was a problem hiding this comment.
- 用了 latestVisualSelected 避免监听 visualSelected 的 change
- 剥离 doThumbAnimation 方法避免额外依赖项
cc @zombieJ
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix ant-design/ant-design#35170