fix: fix jump panel #907

zombieJ · 2025-02-09T08:56:05Z

修复动画态下，初始化会有位移的问题。

Summary by CodeRabbit

Bug Fixes
- 优化了弹出组件的显示位置逻辑，改进了偏移计算，确保在各种情况下都能稳定显示弹出内容。

vercel · 2025-02-09T08:56:10Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
picker	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Feb 9, 2025 8:56am

coderabbitai · 2025-02-09T08:56:12Z

Walkthrough

此次修改在 Popup 组件的 React.useEffect 钩子内，更新了条件判断逻辑。现在会先检查 containerWidth 是否有定义，再与 selectorWidth 作比较，从而避免对 undefined 值进行不当比较。总体控制流程未发生改变，仅增强了防错处理。

Changes

文件路径	变更内容
src/PickerInput/.../index.tsx	在 useEffect 内增加对 containerWidth 定义的判断，防止 undefined 比较

Sequence Diagram(s)

sequenceDiagram
    participant Popup as Popup组件
    participant UE as useEffect钩子
    participant Check as 条件判断
    participant Offset as 计算并设置offset

    Popup->>UE: 触发useEffect
    UE->>Check: 检查 containerWidth 是否定义
    alt containerWidth已定义
        Check->>Check: 判断 containerWidth < selectorWidth?
        alt 条件满足
            Check->>Offset: 计算并设置offset
        else 条件不满足
            Check->>UE: 无需设置offset
        end
    else containerWidth未定义
        Check->>UE: 跳过计算offset
    end

Poem

嗨，我是一只调皮的小兔🐰，
代码草原里增添新防护，
宽度判断精心布置，
逻辑流畅轻轻跳跃，
快乐编码共赏这美妙的演出！

Warning

There were issues while running some tools. Please review the errors and either fix the tool’s configuration or disable the tool if it’s a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

src/PickerInput/Popup/index.tsx

Oops! Something went wrong! :(

ESLint: 8.57.1

Error: Cannot read config file: /.eslintrc.js
Error: Cannot find module '@umijs/fabric/dist/eslint'
Require stack:

/.eslintrc.js
/node_modules/.pnpm/@eslint+eslintrc@2.1.4/node_modules/@eslint/eslintrc/dist/eslintrc.cjs
/node_modules/.pnpm/eslint@8.57.1/node_modules/eslint/lib/cli-engine/cli-engine.js
/node_modules/.pnpm/eslint@8.57.1/node_modules/eslint/lib/eslint/eslint.js
/node_modules/.pnpm/eslint@8.57.1/node_modules/eslint/lib/eslint/index.js
/node_modules/.pnpm/eslint@8.57.1/node_modules/eslint/lib/cli.js
/node_modules/.pnpm/eslint@8.57.1/node_modules/eslint/bin/eslint.js
at Module._resolveFilename (node:internal/modules/cjs/loader:1248:15)
at Function.resolve (node:internal/modules/helpers:145:19)
at Object. (/.eslintrc.js:2:21)
at Module._compile (node:internal/modules/cjs/loader:1546:14)
at Module._extensions..js (node:internal/modules/cjs/loader:1691:10)
at Module.load (node:internal/modules/cjs/loader:1317:32)
at Module._load (node:internal/modules/cjs/loader:1127:12)
at TracingChannel.traceSync (node:diagnostics_channel:315:14)
at wrapModuleLoad (node:internal/modules/cjs/loader:217:24)
at Module.require (node:internal/modules/cjs/loader:1339:12)

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 6b29e0c and 710d4a2.

📒 Files selected for processing (1)

src/PickerInput/Popup/index.tsx (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (2)

GitHub Check: test / react component workflow
GitHub Check: Analyze (javascript-typescript)

🔇 Additional comments (1)

src/PickerInput/Popup/index.tsx (1)

121-121: 优化了容器宽度的判断逻辑！

通过添加 containerWidth 的存在性检查，避免了在初始化阶段出现无效的宽度比较，从而解决了面板的跳动问题。这个改动既简单又有效。

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

codecov · 2025-02-09T08:57:02Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.67%. Comparing base (6b29e0c) to head (710d4a2).
Report is 1 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff           @@
##           master     #907   +/-   ##
=======================================
  Coverage   98.67%   98.67%           
=======================================
  Files          64       64           
  Lines        2648     2648           
  Branches      732      732           
=======================================
  Hits         2613     2613           
  Misses         32       32           
  Partials        3        3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

fix: fix jump panel

710d4a2

zombieJ merged commit 60634f0 into master Feb 9, 2025
11 of 12 checks passed

zombieJ deleted the fix-width branch February 9, 2025 08:58

coderabbitai bot mentioned this pull request Feb 17, 2025

fix: arrow position retry #909

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

fix: fix jump panel #907

fix: fix jump panel #907

Uh oh!

zombieJ commented Feb 9, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

vercel bot commented Feb 9, 2025

Uh oh!

coderabbitai bot commented Feb 9, 2025 •

edited

Loading

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

codecov bot commented Feb 9, 2025 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

fix: fix jump panel #907

fix: fix jump panel #907

Uh oh!

Conversation

zombieJ commented Feb 9, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

vercel bot commented Feb 9, 2025

Uh oh!

coderabbitai bot commented Feb 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Sequence Diagram(s)

Poem

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

codecov bot commented Feb 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Uh oh!

zombieJ commented Feb 9, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Feb 9, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

codecov bot commented Feb 9, 2025 •

edited

Loading