fix(WeekPicker):cross year select not selected at panel#751
Open
huiliangShen wants to merge 1 commit intoreact-component:2.7.xfrom
Open
fix(WeekPicker):cross year select not selected at panel#751huiliangShen wants to merge 1 commit intoreact-component:2.7.xfrom
huiliangShen wants to merge 1 commit intoreact-component:2.7.xfrom
Conversation
|
Someone is attempting to deploy a commit to the React Component Team on Vercel. A member of the Team first needs to authorize it. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 2.7.x #751 +/- ##
=======================================
Coverage 99.09% 99.09%
=======================================
Files 47 47
Lines 2215 2217 +2
Branches 675 675
=======================================
+ Hits 2195 2197 +2
Misses 18 18
Partials 2 2 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix antd@4.x bug 周选择时间控件选中跨年周时无高亮问题
It's cause
isSameWeekfunction. for example: use 2024 first week, first date is2023-12-31(sunday) when local is US.so when I click
2024-01-01, it's will be run the following code.isSameWeekreceivegenerateConfig,US,2024-01-01and2023-12-31, following logic, it's will be return false, because the two date is not same year. we need to usegenerateConfig.locale.getWeekFirstDatefunction to calc date then judge is same year.