Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(generate): dayjs default strict mode #534

Merged
merged 2 commits into from
Nov 23, 2022

Conversation

huangkairan
Copy link
Contributor

@huangkairan huangkairan commented Nov 23, 2022

@vercel
Copy link

vercel bot commented Nov 23, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
picker ❌ Failed (Inspect) Nov 23, 2022 at 5:55AM (UTC)

@huangkairan huangkairan changed the title fix(generate): dayjs.parse default strict mode fix(generate): dayjs default strict mode Nov 23, 2022
@@ -162,7 +162,7 @@ const generateConfig: GenerateConfig<Dayjs> = {
parseNoMatchNotice();
return null;
}
const date = dayjs(formatText, format).locale(localeStr);
const date = dayjs(formatText, format, true).locale(localeStr);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

加个测试用例哈~

@codecov
Copy link

codecov bot commented Nov 23, 2022

Codecov Report

Merging #534 (fccba0c) into master (66b486d) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #534   +/-   ##
=======================================
  Coverage   99.32%   99.32%           
=======================================
  Files          49       49           
  Lines        2236     2236           
  Branches      652      652           
=======================================
  Hits         2221     2221           
  Misses         13       13           
  Partials        2        2           
Impacted Files Coverage Δ
src/generate/dayjs.ts 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Collaborator

@iamkun iamkun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zombieJ zombieJ merged commit fe24ff0 into react-component:master Nov 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants