Skip to content

Update index.ts to fix typescript error #548

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

heath-freenome
Copy link

Fixing #547 by changing the exporting of types to use a typescript safe notation

Copy link

vercel bot commented Dec 12, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
pagination ❌ Failed (Inspect) Dec 12, 2023 6:43pm

@heath-freenome
Copy link
Author

I'm not sure what's going wrong since I can't seem to get into vercel

Copy link

codecov bot commented Dec 13, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a708727) 98.70% compared to head (3e2860b) 98.70%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #548   +/-   ##
=======================================
  Coverage   98.70%   98.70%           
=======================================
  Files           3        3           
  Lines         309      309           
  Branches      136      136           
=======================================
  Hits          305      305           
  Misses          4        4           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zombieJ
Copy link
Member

zombieJ commented Dec 13, 2023

Seems not make sense. interface only provide the type def, which should be type

@heath-freenome
Copy link
Author

Seems not make sense. interface only provide the type def, which should be type

If you checkout the issue, you'll see that the Typescript compiler doesn't like the notation used. Removing the type keyword has the same effect with a file of types and avoids the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants