Skip to content

docs: fix dumi demo #328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 15, 2021
Merged

docs: fix dumi demo #328

merged 4 commits into from
Mar 15, 2021

Conversation

xrkffgg
Copy link
Member

@xrkffgg xrkffgg commented Mar 15, 2021

fix dumi demo
close #326

@vercel
Copy link

vercel bot commented Mar 15, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/react-component/pagination/9gowTRJDnnJCg5yjb1HAT7qGeEQs
✅ Preview: https://pagination-git-curr-react-component.vercel.app

@codecov
Copy link

codecov bot commented Mar 15, 2021

Codecov Report

Merging #328 (352554c) into master (4892927) will increase coverage by 0.06%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #328      +/-   ##
==========================================
+ Coverage   92.35%   92.42%   +0.06%     
==========================================
  Files           3        3              
  Lines         327      330       +3     
  Branches      113      114       +1     
==========================================
+ Hits          302      305       +3     
  Misses         25       25              
Impacted Files Coverage Δ
src/Pagination.jsx 91.05% <100.00%> (+0.10%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4892927...6eb6b1b. Read the comment docs.

@yoyo837
Copy link
Member

yoyo837 commented Mar 15, 2021

个人建议jsx 化,分开PR

@xrkffgg
Copy link
Member Author

xrkffgg commented Mar 15, 2021

那我先修复 dumi 的

@xrkffgg xrkffgg marked this pull request as draft March 15, 2021 08:28
@xrkffgg xrkffgg marked this pull request as ready for review March 15, 2021 08:33
@xrkffgg xrkffgg changed the title fix: page focus when current not change docs: fix dumi demo Mar 15, 2021
@xrkffgg xrkffgg merged commit 1254cc6 into master Mar 15, 2021
@xrkffgg xrkffgg deleted the curr branch March 15, 2021 08:36
@afc163
Copy link
Member

afc163 commented Mar 15, 2021

可以建一个 issue 或者 project 跟踪一下所有 rc 组件的迁移。

@xrkffgg
Copy link
Member Author

xrkffgg commented Mar 15, 2021

@afc163 react-component/field-form#238

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Broken API table
3 participants