Skip to content

fix: click some page & prev btn #323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 5, 2021
Merged

fix: click some page & prev btn #323

merged 2 commits into from
Mar 5, 2021

Conversation

xrkffgg
Copy link
Member

@xrkffgg xrkffgg commented Feb 27, 2021

close ant-design/ant-design#29512


之前有个判断 上一页下一页的按钮,但其实点击触发的不是相应的,而是里层的 -item-link。这里修复了下。

增加了 点击 分页的判断,同时这两种情况 都会清空 input 。

@vercel
Copy link

vercel bot commented Feb 27, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/react-component/pagination/FrtB79LMJTXBbNGZcUYNXKCtTn1o
✅ Preview: https://pagination-git-fix-click-react-component.vercel.app

@xrkffgg xrkffgg requested a review from kerm1it February 27, 2021 07:36
@xrkffgg xrkffgg requested review from afc163 and zombieJ February 27, 2021 07:41
@kerm1it

This comment has been minimized.

@xrkffgg
Copy link
Member Author

xrkffgg commented Mar 1, 2021

我现在就是在这个地方加的判断。

逻辑是,如果是 页数按钮 或 上一页下一页的 button 触发的 input 的 blur,会清空 input 的值,并停止 input blur 的改变,而以外层点击的 改变 为准。

@xrkffgg
Copy link
Member Author

xrkffgg commented Mar 1, 2021

我的想法,用户在输入的时候,是想去某一页,但却选择了点击其他页的形式,表示他的意愿更偏向于点击的那一页。

然后用户改变分页的意愿完成,input 清空。

不然留着会造成歧义,并且不经意的 blur 就会又改变页数。

@codecov
Copy link

codecov bot commented Mar 1, 2021

Codecov Report

Merging #323 (6ba5537) into master (0bbe863) will increase coverage by 0.91%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #323      +/-   ##
==========================================
+ Coverage   91.43%   92.35%   +0.91%     
==========================================
  Files           3        3              
  Lines         327      327              
  Branches      113      113              
==========================================
+ Hits          299      302       +3     
+ Misses         28       25       -3     
Impacted Files Coverage Δ
src/Options.jsx 98.43% <100.00%> (+4.68%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0bbe863...6ba5537. Read the comment docs.

@xrkffgg
Copy link
Member Author

xrkffgg commented Mar 1, 2021

@afc163 @zombieJ PTAL

@kerm1it kerm1it merged commit a90eae1 into master Mar 5, 2021
@kerm1it kerm1it deleted the fix-click branch March 5, 2021 03:20
@kerm1it
Copy link
Member

kerm1it commented Mar 5, 2021

@zombieJ @afc163 看看没问题,有空发个 patch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

使用分页器选择出现同时选中两个页码的情况
2 participants