Skip to content

fix: always render #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 21, 2022
Merged

fix: always render #20

merged 1 commit into from
Apr 21, 2022

Conversation

zombieJ
Copy link
Member

@zombieJ zombieJ commented Apr 20, 2022

fix ant-design/ant-design#35117

直接返回 null 导致不会生成 MenuItem 也就不会有 OverflowItem 导致永远都收集不到,语法糖返回东西是无法确定的,这里只能再兜一次底。

@vercel
Copy link

vercel bot commented Apr 20, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
overflow ✅ Ready (Inspect) Visit Preview Apr 20, 2022 at 11:38AM (UTC)

@codecov
Copy link

codecov bot commented Apr 20, 2022

Codecov Report

Merging #20 (14e8cba) into master (15f632d) will decrease coverage by 0.50%.
The diff coverage is 75.00%.

@@             Coverage Diff             @@
##            master      #20      +/-   ##
===========================================
- Coverage   100.00%   99.49%   -0.51%     
===========================================
  Files            4        4              
  Lines          195      197       +2     
  Branches        60       62       +2     
===========================================
+ Hits           195      196       +1     
- Misses           0        1       +1     
Impacted Files Coverage Δ
src/Overflow.tsx 99.27% <75.00%> (-0.73%) ⬇️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Menu.Item can be hidden in horizontal mode
1 participant