Skip to content

Conversation

@yociduo
Copy link
Contributor

@yociduo yociduo commented Apr 9, 2024

@vercel
Copy link

vercel bot commented Apr 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
notification ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 11, 2024 3:36am

@afc163
Copy link
Member

afc163 commented May 7, 2024

  1. hover 到 notificiation 上时,progress 应该是暂停,总之不应该消失。看上去还需要一个 pauseOnHover: boolean;
  2. 是否应该是反向 progresss?

参考 https://fkhadra.github.io/react-toastify/introduction/

@yociduo
Copy link
Contributor Author

yociduo commented May 8, 2024

  1. hover 到 notificiation 上时,progress 应该是暂停,总之不应该消失。看上去还需要一个 pauseOnHover: boolean;
  2. 是否应该是反向 progresss?

参考 https://fkhadra.github.io/react-toastify/introduction/

  1. 是沿用旧逻辑,我先让它不消失吧。这个新的属性是新开个pr改,还是就在当前这个改掉。我觉得加了这个的话,closeOnClick: boolean也应该加上。
  2. 这个倒是正反的都看到过,按你说的我改一下,改成反向的。
  3. showProgress -> showProgressBar 这个属性这样改是不是好一点

@afc163
Copy link
Member

afc163 commented May 8, 2024

showProgress 就行了。

@afc163
Copy link
Member

afc163 commented May 11, 2024

hover 后现在是暂停的,但是鼠标离开后重新计时了,预期应该是从上次时刻继续。

Copy link
Member

@afc163 afc163 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hover 后现在是暂停的,但是鼠标离开后重新计时了,预期应该是从上次时刻继续。

@yociduo
Copy link
Contributor Author

yociduo commented May 11, 2024

hover 后现在是暂停的,但是鼠标离开后重新计时了,预期应该是从上次时刻继续。

这个更新了,顺便加了一下测试用例

@afc163 afc163 merged commit 06a471c into react-component:master May 11, 2024
@yociduo yociduo deleted the feat/show-progess branch May 20, 2024 01:12
@yociduo yociduo restored the feat/show-progess branch May 20, 2024 01:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Show progress bar for auto-closing notification

2 participants