Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support for submenu custom styles #645

Merged
merged 8 commits into from
Jul 1, 2023
Merged

feat: support for submenu custom styles #645

merged 8 commits into from
Jul 1, 2023

Conversation

yangxiuxiu1115
Copy link
Contributor

@yangxiuxiu1115 yangxiuxiu1115 commented Jun 3, 2023

@codecov
Copy link

codecov bot commented Jun 5, 2023

Codecov Report

Merging #645 (20d82c5) into master (8f89f99) will not change coverage.
The diff coverage is n/a.

❗ Current head 20d82c5 differs from pull request most recent head 6c7c0fd. Consider uploading reports for the commit 6c7c0fd to get more accurate results

@@           Coverage Diff           @@
##           master     #645   +/-   ##
=======================================
  Coverage   99.57%   99.57%           
=======================================
  Files          26       26           
  Lines         711      711           
  Branches      194      191    -3     
=======================================
  Hits          708      708           
  Misses          3        3           
Impacted Files Coverage Δ
src/SubMenu/PopupTrigger.tsx 100.00% <ø> (ø)
src/SubMenu/index.tsx 100.00% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@yoyo837
Copy link
Member

yoyo837 commented Jun 5, 2023

请再添加一个测试用例覆盖一下

@yangxiuxiu1115
Copy link
Contributor Author

yangxiuxiu1115 commented Jun 14, 2023

我不太确定我提的pr符合issue。或许放到SubMenuType下更为合适,支持每个submenu都支持自定义style。而不是目前我实现的形式。

@yangxiuxiu1115
Copy link
Contributor Author

我也看到了另一处的评论, rc-trigger已经被废弃了吗?如果已经被废弃的话,请忽略这个PR。

@yoyo837
Copy link
Member

yoyo837 commented Jun 14, 2023

rc-trigger 被废弃了, 由 @rc-component/trigger 接替, 你可以同步一下master

@yoyo837
Copy link
Member

yoyo837 commented Jun 16, 2023

文档和用例也加一下?

@afc163 afc163 merged commit 441804b into react-component:master Jul 1, 2023
@afc163
Copy link
Member

afc163 commented Jul 1, 2023

Could you update rc-menu version in antd and the documentation. https://github.com/react-component/menu/releases/tag/v9.11.0

@yangxiuxiu1115
Copy link
Contributor Author

Could you update rc-menu version in antd and the documentation. https://github.com/react-component/menu/releases/tag/v9.11.0

好的,稍后更新。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SubMenu增加支持透传给rc-trigger的popupStyle参数
3 participants