fix: Resolve console error when MenuItem uses popupClassName #606
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
要不改成解构? |
Codecov Report
@@ Coverage Diff @@
## master #606 +/- ##
=======================================
Coverage 99.85% 99.85%
=======================================
Files 26 26
Lines 710 710
Branches 194 191 -3
=======================================
Hits 709 709
Misses 1 1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
是改成这种的么？ |
比起omit, 个人更喜欢这种, 还不依赖别的. |
|
同志们推进一下这个 PR 呗？ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: ant-design/ant-design#41395
原因：由于在非
SubMenu上使用了popupClassName属性，在整个过程中没有进行处理，最终该属性会被设置到 DOM 元素上去，但是 React 不识别 DOM 元素非标准的属性，因此出现报错。解决方案：将
popupClassName等一些未使用到的非标准的属性进行过滤。