Skip to content

Conversation

thinkasany
Copy link
Contributor

@thinkasany thinkasany commented Feb 25, 2025

Summary by CodeRabbit

  • 新功能
    • 组件现支持自定义弹窗样式,用户可通过设置特定样式及类名来自定义弹窗和文本区域的外观。
  • 测试
    • 更新测试用例以反映新的类名,并新增测试用例,验证自定义样式和类名在弹窗及文本区域中的正确应用,确保功能如预期工作。

Copy link

coderabbitai bot commented Feb 25, 2025

Walkthrough

此次更改在两个组件中增加了自定义样式的支持。在 KeywordTrigger.tsx 中,为 KeywordTriggerProps 接口添加了可选的 popupStyle 属性,并将其传递给 Trigger 组件。在 Mentions.tsx 中,扩展了 MentionsProps 接口,为 classNamesstyles 分别增加了 textareapopup 属性,使得可对文本区域和弹出框进行更精细的样式定制。同时,新增的测试用例验证了这些样式与类名的正确应用。

Changes

文件路径 更改摘要
src/KeywordTrigger.tsx KeywordTriggerProps 接口新增 popupStyle?: React.CSSProperties 属性,并将其传递给 Trigger 组件。
src/Mentions.tsx 扩展 MentionsProps 接口,classNamesstyles 对象中分别添加 textareapopup 属性,更新了相应组件的属性传递。
tests/Mentions.spec.tsx 新增测试用例,验证 Mentions 组件中下拉菜单与文本区域的自定义类名和样式是否正常生效。
docs/examples/onScroll.tsx Mentions 组件中的 dropdownClassName 属性更改为 popupClassName
package.json 更新依赖 @rc-component/input 的版本,从 ~1.0.0 更改为 ~1.0.1

Sequence Diagram(s)

sequenceDiagram
    participant M as Mentions
    participant IM as InternalMentions
    participant TA as TextArea
    participant KT as KeywordTrigger
    participant T as Trigger

    M->>IM: 传递 classNames 与 styles (textarea, popup)
    IM->>TA: 应用textarea的classNames与styles
    IM->>KT: 应用popup的classNames与styles
    KT->>T: 传递popupStyle属性
Loading

Possibly related PRs

  • fix: react warnings #276: 该PR涉及对 MentionsProps 接口中 dropdownClassName 属性的修改,与本PR的更新相互关联。
  • chore: update deps #285: 该PR同样修改了 MentionsProps 接口,替换了 dropdownClassName 属性为 popupClassName,与本PR直接相关。

Suggested reviewers

  • zombieJ

Poem

森林中我蹦跳不停,
代码之花悄然绽放;
样式灵动如露珠晶莹,
弹窗轻舞讲述新风尚;
萌兔庆祝变更时,
萌心满满乐淘淘!
🥕🌙🐇


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 2d23534 and c9dcf53.

⛔ Files ignored due to path filters (1)
  • tests/__snapshots__/AllowClear.spec.tsx.snap is excluded by !**/*.snap
📒 Files selected for processing (1)
  • package.json (1 hunks)
✅ Files skipped from review due to trivial changes (1)
  • package.json
⏰ Context from checks skipped due to timeout of 90000ms (1)
  • GitHub Check: Socket Security: Pull Request Alerts

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

src/Mentions.tsx Outdated
visible
getPopupContainer={getPopupContainer}
dropdownClassName={dropdownClassName}
dropdownClassName={classNames(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

popupClassName?

@zombieJ zombieJ merged commit 40b1315 into react-component:master Feb 26, 2025
5 checks passed
Copy link

codecov bot commented Feb 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.39%. Comparing base (843d868) to head (c9dcf53).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #289   +/-   ##
=======================================
  Coverage   98.39%   98.39%           
=======================================
  Files           7        7           
  Lines         249      249           
  Branches       58       58           
=======================================
  Hits          245      245           
  Misses          4        4           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants