Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore type is hidden #169

Merged
merged 1 commit into from
Jul 11, 2018
Merged

Ignore type is hidden #169

merged 1 commit into from
Jul 11, 2018

Conversation

HsuTing
Copy link
Contributor

@HsuTing HsuTing commented Jun 13, 2018

If input.type is hidden, top is always 0.

@yesmeck
Copy link
Member

yesmeck commented Jun 21, 2018

Hidden input in react is useless.

@HsuTing
Copy link
Contributor Author

HsuTing commented Jun 21, 2018

Why?
Hidden input is rarely used, but I do not think this is useless.
In my case, I need to use this, and I do not think ignore hidden have an problem.
This can let this component more flexible.

@yesmeck
Copy link
Member

yesmeck commented Jun 21, 2018

You should store the value of hidden input in the state.

@HsuTing
Copy link
Contributor Author

HsuTing commented Jun 21, 2018

Yes, I agree, but I need to use hidden input for the some reason.
Maybe you can think about this issue.
If you do not want this, close this issue, please.

Thank you for you replay 😁.

@benjycui benjycui merged commit f197a08 into react-component:master Jul 11, 2018
@benjycui
Copy link
Member

2.2.1

@HsuTing HsuTing deleted the fix-type-hidden branch July 11, 2018 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@HsuTing @yesmeck @benjycui