Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose type autoDestroy from @rc-component/trigger & fix test coverage #233

Merged
merged 2 commits into from
Nov 17, 2023

Conversation

xettri
Copy link
Contributor

@xettri xettri commented Nov 16, 2023

Exposed autoDestroy prop in rc-dropdown from TriggerProps as its useful when we need to destroy after dropdown close for custom overlay. Currently for this hack is required and need to extend TriggerProps manually with @rc-component/trigger

@yoyo837
Copy link
Member

yoyo837 commented Nov 17, 2023

CI failed

@xettri
Copy link
Contributor Author

xettri commented Nov 17, 2023

@yoyo837 same fail for master as well for me, I don't think this pull request changes breaks its coverage, looks some other major issue.

@xettri
Copy link
Contributor Author

xettri commented Nov 17, 2023

fix: updated basic test snapshot to fix test coverage

Copy link

codecov bot commented Nov 17, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (de18711) 100.00% compared to head (be446b8) 100.00%.

❗ Current head be446b8 differs from pull request most recent head 83e30dc. Consider uploading reports for the commit 83e30dc to get more accurate results

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #233   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            5         5           
  Lines          107       107           
  Branches        31        31           
=========================================
  Hits           107       107           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@xettri xettri changed the title Expose type autoDestroy from @rc-component/trigger Expose type autoDestroy from @rc-component/trigger & fix test coverage Nov 17, 2023
@yoyo837 yoyo837 merged commit 6138657 into react-component:master Nov 17, 2023
@xettri xettri deleted the expose-rc-trigger-type branch November 17, 2023 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants