fix: Mask from true to false without animation

[EmilyyyLiu]

fix ant-design/ant-design#53917

Summary by CodeRabbit

• Bug Fixes
  • 修复抽屉弹窗遮罩动画在特定条件下显示异常的问题，确保仅在遮罩开启且抽屉打开时才显示遮罩动画。

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
drawer	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	May 28, 2025 7:23am

[coderabbitai]

Walkthrough

本次更改调整了 Drawer 组件中遮罩动画的渲染逻辑。现在无论 mask 属性是否为 true，CSSMotion 组件始终渲染，但其 visible 属性由 mask 和 open 的与运算共同控制，从而保证 mask 关闭时也有渐变动画。

Changes

文件/分组	变更摘要
src/DrawerPopup.tsx	修改了 mask 动画的渲染逻辑，始终渲染 CSSMotion 组件，并通过 mask && open 控制 visible 属性

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant DrawerPopup
    participant CSSMotion

    User->>DrawerPopup: 设置 mask 属性（true/false）
    User->>DrawerPopup: 切换 open 状态
    DrawerPopup->>CSSMotion: 传递 visible = mask && open
    CSSMotion-->>DrawerPopup: 渲染遮罩并处理渐变动画

Loading

Assessment against linked issues

Objective	Addressed	Explanation
Drawer 的 mask 属性从 true 变为 false 时保留渐变（#53917）	✅

Poem

小兔子码云间，
遮罩渐变更自然。
mask 真假皆有影，
动画流畅不再烦。
轻推抽屉随心意，
渐变随风舞翩跹。
🐇✨

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

src/DrawerPopup.tsx

Oops! Something went wrong! :(

ESLint: 8.57.1

Error: Cannot read config file: /.eslintrc.js
Error: Cannot find module '@umijs/fabric/dist/eslint'
Require stack:

• /.eslintrc.js
• /node_modules/.pnpm/@eslint+eslintrc@2.1.4/node_modules/@eslint/eslintrc/dist/eslintrc.cjs
• /node_modules/.pnpm/eslint@8.57.1/node_modules/eslint/lib/cli-engine/cli-engine.js
• /node_modules/.pnpm/eslint@8.57.1/node_modules/eslint/lib/eslint/eslint.js
• /node_modules/.pnpm/eslint@8.57.1/node_modules/eslint/lib/eslint/index.js
• /node_modules/.pnpm/eslint@8.57.1/node_modules/eslint/lib/cli.js
• /node_modules/.pnpm/eslint@8.57.1/node_modules/eslint/bin/eslint.js
  at Module._resolveFilename (node:internal/modules/cjs/loader:1405:15)
  at require.resolve (node:internal/modules/helpers:145:19)
  at Object. (/.eslintrc.js:2:21)
  at Module._compile (node:internal/modules/cjs/loader:1734:14)
  at Object..js (node:internal/modules/cjs/loader:1899:10)
  at Module.load (node:internal/modules/cjs/loader:1469:32)
  at Module._load (node:internal/modules/cjs/loader:1286:12)
  at TracingChannel.traceSync (node:diagnostics_channel:322:14)
  at wrapModuleLoad (node:internal/modules/cjs/loader:235:24)
  at Module.require (node:internal/modules/cjs/loader:1491:12)

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 283ead8 and 503e4f8.

📒 Files selected for processing (1)

• src/DrawerPopup.tsx (1 hunks)

🔇 Additional comments (1)

src/DrawerPopup.tsx (1)

223-224: 正确修复了遮罩动画问题

这个改动很好地解决了遮罩从显示到隐藏时缺少动画的问题。通过始终渲染 CSSMotion 组件并用 visible={mask && open} 控制可见性，确保了：

1. 组件始终挂载在 DOM 中，可以正确处理进入和退出动画
2. 当 mask 从 true 变为 false 时，CSSMotion 可以播放退出动画
3. 逻辑 mask && open 正确表达了遮罩应该在遮罩启用且抽屉打开时才显示

这种方法比条件渲染更适合需要动画过渡的场景。

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (283ead8) to head (503e4f8).
Report is 1 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff            @@
##            master      #490   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            5         5           
  Lines          145       144    -1     
  Branches        54        53    -1     
=========================================
- Hits           145       144    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.