Skip to content

feat: add afterOpen prop #251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

Amour1688
Copy link

No description provided.

@vercel
Copy link

vercel bot commented Mar 23, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/react-component/dialog/EBARACraGyt1WFYxBhhjJRS1L3a5
✅ Preview: https://dialog-git-fork-amour1688-master-react-component.vercel.app

@zombieJ
Copy link
Member

zombieJ commented Mar 23, 2021

test case 来一个

@codecov
Copy link

codecov bot commented Mar 23, 2021

Codecov Report

Merging #251 (5b66236) into master (21a143a) will increase coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head 5b66236 differs from pull request most recent head 61d1476. Consider uploading reports for the commit 61d1476 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #251      +/-   ##
==========================================
+ Coverage   98.12%   98.13%   +0.01%     
==========================================
  Files           6        6              
  Lines         160      161       +1     
  Branches       47       47              
==========================================
+ Hits          157      158       +1     
  Misses          2        2              
  Partials        1        1              
Impacted Files Coverage Δ
src/Dialog/index.tsx 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 21a143a...61d1476. Read the comment docs.

@afc163
Copy link
Member

afc163 commented Feb 20, 2023

冲突了

@afc163
Copy link
Member

afc163 commented Feb 20, 2023

是不是把 onOpenChanged 暴露出来更好?cc @zombieJ

@MuxinFeng
Copy link
Contributor

是不是把 onOpenChanged 暴露出来更好?cc @zombieJ

这个 pr 大佬在跟嘛,要是暂时没精力看,我可以试试看👀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants