Skip to content

feat: virtual list #545

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

webMasterMrBin
Copy link

@webMasterMrBin webMasterMrBin commented Nov 11, 2024

ant-design/ant-design#26645
增加虚拟列表功能 优化大数据量体验

基于3.12.1切的分支 希望发布�3.12.x小版本

Summary by CodeRabbit

  • 新功能

    • 增加了可选属性 virtuallistHeightlistItemHeight,可用于自定义下拉菜单的渲染行为。
    • 引入虚拟列表渲染选项,优化大数据集的性能。
  • 修复

    • 更新了激活滚动逻辑,以适应虚拟化状态,提升用户体验。

Copy link

vercel bot commented Nov 11, 2024

Someone is attempting to deploy a commit to the React Component Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

coderabbitai bot commented Nov 11, 2024

Caution

Review failed

The pull request is closed.

Walkthrough

本次变更主要涉及对rc-cascader项目的多个文件进行修改。package.json文件中新增了对rc-virtual-list的依赖。src/Cascader.tsx文件中添加了virtuallistHeightlistItemHeight属性,以增强下拉菜单的自定义功能。src/OptionList/Column.tsx文件中重构了渲染逻辑,以支持虚拟列表的渲染。src/OptionList/index.tsxsrc/context.ts文件中也相应地更新了上下文以支持新的属性,增强了组件的控制流和性能。

Changes

文件路径 变更摘要
package.json 新增依赖:"rc-virtual-list": "^3.14.8"
src/Cascader.tsx BaseCascaderProps接口中新增属性:virtual?: booleanlistHeight?: numberlistItemHeight?: number
src/OptionList/Column.tsx 引入rc-virtual-list,使用虚拟列表渲染选项,新增const ref = React.useRef<ListRef>(null),更新渲染逻辑以支持虚拟列表。
src/OptionList/index.tsx CascaderContext中新增virtual属性,更新useEffect钩子的依赖数组以包含virtual
src/context.ts CascaderContextProps接口中新增属性:virtual?: booleanlistHeight?: numberlistItemHeight?: number

Possibly related PRs

  • chore: upgrade deps #542: 此PR与主PR相关,因为两者都涉及对package.json文件的更新,尽管主PR新增了依赖,而此PR更新了现有依赖。

Poem

在草地上跳跃的小兔子,
新依赖让我们更灵活,
虚拟列表如风般轻,
下拉菜单更显风采,
让我们一起欢呼吧! 🐇✨


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant