Skip to content

Conversation

@woro83c
Copy link

@woro83c woro83c commented Sep 5, 2019

RE #295

@bpas247
Copy link
Member

bpas247 commented Sep 5, 2019

just like #446 (comment), we'll need to merge the changes from master into this branch in order for the required status checks to kick off properly.

@woro83c
Copy link
Author

woro83c commented Oct 17, 2019

what still remains on this for it to be merged in?

@taion
Copy link
Member

taion commented Oct 17, 2019

@jquense are you okay with this? this looks like a breaking change.

alternatively, we'd need to keep supporting the old API as a deprecated thing for now. otherwise this would have to be 3.x

@ericyliu
Copy link

what's the status on this PR?

@taion taion requested a review from jquense August 11, 2020 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants