fix: pass actual text to footerFormatter instead of column array#1147
Closed
pdrgds wants to merge 1 commit intoreact-bootstrap-table:masterfrom
pdrgds:master
Closed
fix: pass actual text to footerFormatter instead of column array#1147pdrgds wants to merge 1 commit intoreact-bootstrap-table:masterfrom pdrgds:master
pdrgds wants to merge 1 commit intoreact-bootstrap-table:masterfrom
pdrgds:master
Conversation
AllenFang
reviewed
Nov 16, 2019
| if (!_.isEmptyObject(cellStyle)) cellAttrs.style = cellStyle; | ||
|
|
||
| const children = footerFormatter ? footerFormatter(column, index) : text; | ||
| const children = footerFormatter ? footerFormatter(text) : text; |
Member
There was a problem hiding this comment.
hello @pdrgds please give text as first argument but keep index as second argument. thanks
AllenFang
requested changes
Nov 16, 2019
Member
AllenFang
left a comment
AllenFang
left a comment
There was a problem hiding this comment.
Please check my comment and change your target branch to develop instead of master. btw, remember to rebase your code. thanks you contribution~
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It doesn't make any sense to receive an array with column items in this function, since this is already done in the "footer" function.
Example: let's say I do just like in the Storybook example:
const columns = [ { dataField: 'price', text: 'Product Price', footer: columnData => columnData.reduce((acc, item) => acc + item, 0) }];footFormatter should just receive the result of this already executed function so I can format it.