Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/remove babel-preset-es2015-webpack #838

Merged
merged 5 commits into from
Aug 5, 2016
Merged

Feature/remove babel-preset-es2015-webpack #838

merged 5 commits into from
Aug 5, 2016

Conversation

andykenward
Copy link
Contributor

Since the latest release of babel-core and babel-preset-2015 (6.13.2) can handle presets options.
No longer need to use babel-preset-es2015-webpack

Thanks goes to @zoontek on gajus/babel-preset-es2015-webpack#14 (comment)

Andy Kenward added 3 commits August 5, 2016 09:22
@coveralls
Copy link

Coverage Status

Coverage remained the same at 98.447% when pulling b2eb066 on andykenward:feature/remove_babel_preset_es2015_webpack into 340cd5f on mxstbr:master.

@mxstbr
Copy link
Member

mxstbr commented Aug 5, 2016

This is great! 🎉 Can we undo the other whitespace changes?

@andykenward
Copy link
Contributor Author

@mxstbr whitespace done by npm automatically when the package were updated via command line. So will come back eventually even if they are removed

@coveralls
Copy link

Coverage Status

Coverage remained the same at 98.447% when pulling 8806518 on andykenward:feature/remove_babel_preset_es2015_webpack into 396f2d1 on mxstbr:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 98.447% when pulling 8806518 on andykenward:feature/remove_babel_preset_es2015_webpack into 396f2d1 on mxstbr:master.

@mxstbr
Copy link
Member

mxstbr commented Aug 5, 2016

Awesome, thanks!

@mxstbr mxstbr merged commit b496aa5 into react-boilerplate:master Aug 5, 2016
@garajo
Copy link

garajo commented Aug 11, 2016

Thank you very much for these changes and this thread. I'm trying to implement these changes on an existing react-boilerplate project, but I get the following error after running npm run postinstall.

ERROR in ./~/diffie-hellman/lib/primes.json
Module parse failed: /media/gajo/ssd/home/gajo/local/proyct/bean.cab/broadbean/node_modules/diffie-hellman/lib/primes.json Unexpected token (2:11)
You may need an appropriate loader to handle this file type.

I've looked through package.json and compared my webpack configurations with the latest version of master, but I don't see any difference that would cause this loader failure. Could anyone give a pointer on how I could fix this?

Update:
I was able to eliminate the error by adding the following to webpack.dll.babel.js,

module:{
  loaders: [{ test: /\.json$/, loader: 'json-loader',}],
}

I ran into this problem, because I failed to do a shrinkwrap, and got caught with unwanted dependencies updates, lost specific configs, and was compelled to go ahead and update the es2015 presets. I don't know enough about webpack to have gotten to the underlying cause of the errors, but I'm assuming since the version of react-boilerplate I'm working with is older, my project contains libraries that are breaking with this update, and which are no longer in the current master. But, that's a guess. Hope this is helpful in case someone else gets caught in the same situation.

@andykenward andykenward deleted the feature/remove_babel_preset_es2015_webpack branch September 7, 2016 12:13
@lock
Copy link

lock bot commented May 29, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators May 29, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants