-
Notifications
You must be signed in to change notification settings - Fork 6.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/remove babel-preset-es2015-webpack #838
Feature/remove babel-preset-es2015-webpack #838
Conversation
…at support it. Which should then import es6 version.
…3.2) can handle presets options. No longer need to `babel-preset-es2015-webpack` Thanks goes to @zoontek on gajus/babel-preset-es2015-webpack#14 (comment)
This is great! 🎉 Can we undo the other whitespace changes? |
@mxstbr whitespace done by npm automatically when the package were updated via command line. So will come back eventually even if they are removed |
Awesome, thanks! |
Thank you very much for these changes and this thread. I'm trying to implement these changes on an existing react-boilerplate project, but I get the following error after running
I've looked through package.json and compared my webpack configurations with the latest version of master, but I don't see any difference that would cause this loader failure. Could anyone give a pointer on how I could fix this? Update:
I ran into this problem, because I failed to do a shrinkwrap, and got caught with unwanted dependencies updates, lost specific configs, and was compelled to go ahead and update the es2015 presets. I don't know enough about webpack to have gotten to the underlying cause of the errors, but I'm assuming since the version of react-boilerplate I'm working with is older, my project contains libraries that are breaking with this update, and which are no longer in the current master. But, that's a guess. Hope this is helpful in case someone else gets caught in the same situation. |
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Since the latest release of
babel-core
andbabel-preset-2015
(6.13.2) can handle presets options.No longer need to use
babel-preset-es2015-webpack
Thanks goes to @zoontek on gajus/babel-preset-es2015-webpack#14 (comment)