when HomePage initial state username is not null, submit the form to … #410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
When does this happen? |
|
@mxstbr // The initial state of the App
const initialState = fromJS({
username: 'mxstbr',
});when username have a default value and not null, reload page doesn't load repos. |
|
Maybe we can rewrite it like redux-saga/examples/async demo code |
| @@ -123,7 +132,8 @@ function mapDispatchToProps(dispatch) { | |||
| onChangeUsername: (evt) => dispatch(changeUsername(evt.target.value)), | |||
| changeRoute: (url) => dispatch(push(url)), | |||
| onSubmitForm: (evt) => { | |||
| evt.preventDefault(); | |||
| /* eslint no-unused-expressions: ["error", { "allowShortCircuit": true }] */ | |||
There was a problem hiding this comment.
Change this to // eslint-disable-line no-unused-expressions!
|
Ah, good catch, I like this solution! 👍 One small nitpick, then we can merge this fix—thanks so much! |
|
change it, but npm run lint not pass: 136:7 error Expected an assignment or function call and instead saw an expression no-unused-expressions
✖ 1 problem (1 error, 0 warnings) |
|
Yeah, I think it needs to be on the same line, but this looks fine. Thanks @suhaotian! |
|
@mxstbr My pleasure! |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…load repos