Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dependency upgrades and fixes #2374

Merged
merged 6 commits into from
Oct 9, 2018
Merged

Dependency upgrades and fixes #2374

merged 6 commits into from
Oct 9, 2018

Conversation

julienben
Copy link
Member

  • Fixes
  • Linting/prettier
  • Dependency upgrades
  • Switch Appveyor to npm ci
  • More incoming

@coveralls
Copy link

coveralls commented Oct 9, 2018 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling b88aba1 on dependency-upgrades-and-fixes into f8a738a on dev.

vineyardbovines
vineyardbovines approved these changes Oct 9, 2018
View reviewed changes
Copy link
Member

@vineyardbovines vineyardbovines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It definitely might be worth it to figure out at some point if we can slim down the amount of babel plugins we have

@julienben
Copy link
Member Author

Still working on this! Please don't merge yet!

@julienben
Copy link
Member Author

@Gretzky I agree with you about the high number of Babel plugins. It's the list we reached when going through Babel's official upgrade to 7 instructions/script. Not sure how to slim down the list just yet but I've at least moved the Jest and Babel configs to their own files to get package.json down from 300 to 200 lines.

@julienben julienben merged commit d1c4520 into dev Oct 9, 2018
@julienben julienben deleted the dependency-upgrades-and-fixes branch October 9, 2018 13:56
@vineyardbovines
Copy link
Member

I'll take a look at the babel plugins

@satishjhanwer
Copy link

I saw that dev branch doesn't have husky as a dependency anymore and its being remove while merging this PR. Husky was added in #2072

@Gretzky @julienben, Let me know your thoughts on commit-lint, I see we are not following proper commit messages which makes changelog generation a hard job.

@julienben
Copy link
Member Author

@satishjhanwer What's your point regarding Husky? Does it need to be restored as a dependency?

Re:commit-lint, I wouldn't be against having it for our work here in the RBP repository itself but it might be too much to force it on all the people who clone the repo for their own use.

This is a problem that arises out of our being a project that needs to be cloned rather than one that can be installed as a dependency...

vineyardbovines pushed a commit that referenced this pull request Oct 24, 2018
@julienben @Gretzky
Dependency upgrades and fixes (#2374)
bbbdf24 
- Fixes
- Linting/prettier
- Dependency upgrades
- Switch Appveyor to `npm ci`
- More incoming
@lock
Copy link

lock bot commented Nov 17, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Nov 17, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@vineyardbovines vineyardbovines vineyardbovines approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@julienben @coveralls @vineyardbovines @satishjhanwer