Focus route if active element is not changed by app #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ryanflorence So I've added a check in |
pdhoopr
force-pushed
the
focus-if-app-doesnt
branch
from
9d1a247 to
ee6d374
Compare
pdhoopr
force-pushed
the
focus-if-app-doesnt
branch
from
ee6d374 to
e99039f
Compare
|
has this been fixed? I'm running into this issue currently with reach router@latest |
ryanflorence
added
the
bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #39.
When transitioning between routes, the new route will no longer be focused if the app has already changed the active element elsewhere (for example, a modal).