Support React 17 in peer dependencies, move to a fork of create-react-context

[Hypnosphi]

This is a breaking change-free alternative to #436
Here's the diff between my fork and the original package: https://github.com/jamiebuilds/create-react-context/pull/33/files

[Akiyamka]

LGFM

[nathanaelphilip]

Will this get merged soon? Having some issues with storybook :)

[mikestopcontinues]

Cool stuff! Looks like jamiebuilds repo is dead.

[pd8]

Hi would love to get this in to unblock consumers (and lots of people trying to update storybook), is there any timeline when this will be merged and a new version released @bcomnes ? :)

[bcomnes]

I dunno, whenever a maintainer can be tracked down with a few minutes. I'm external

[pd8]

I dunno, whenever a maintainer can be tracked down with a few minutes. I'm external

Ah my mistake! I thought you were internal in this space!

[Akiyamka]

@ryanflorence, this repo still maintain or currently it's frozen and we must use react-router ?

[silltho]

@Hypnosphi greetings from Salzburg and thank you for this PR.

I would like raise the question if there is a point in using create-react-context polyfill. Couldn't it be exchanged in favor of useContext. I know then reach/router would lose the backwards compatibility to react 15.

However it would be nice if a maintainer could review this, since it's not a huge change and this issue is blocking a lot of people from moving to npm v7.

Please let me know if there is anything I can do to get this merged.

[Hypnosphi]

This is a breaking change-free alternative to #436

[mattpauldavies]

Any news on this folks?

[bcomnes]

Looks like reach-router is getting replaced with react router 5?

Reach Router and it’s sibling project React Router are merging as React Router v6. In other words, Reach Router v2 and React Router v6 are the same. There is more information on the maintainers website.

https://reach.tech/router/

Migration guide here.

https://reacttraining.com/blog/reach-react-router-future/

wrt storybook, @storybook/api@6.2.8 and @storybook/router@6.2.8 would need to migrate over.

Still trying to figure out if that is possible still.

[bcomnes]

Ok, so I looked into moving from reach/router to react-router 6 in the storybook context. Unfortunately in that case there is enough going on to where its involved and not a trivial rename of things.

I do support the effort to get that moved over, but in the meantime, landing this would be extremely helpful. Does anyone have back channels to @ryanflorence or @blainekasten, (or someone who might) to land this simple change in the meantime?

I'll be collecting react-router 6 notes for storybook over in their issue tracker.

[shilman]

@bcomnes Another option would just be to fork @reach/router and do our own release, similar to what @Hypnosphi has done for the create-react-context library.

[bcomnes]

@shilman yeah, that would be a good option too. I would be happy to do that work or let @Hypnosphi do it.

[Himadu2000]

I'm just suggesting, did anyone try the organization email, because if that not responding then it means they actually ignore this repo.

PS: I'm new around here.

[Himadu2000]

@shilman @bcomnes , I also have other packages which are not maintained or because owner doesn't like features (typescript), I would like to create an organization to fix these issues. If you are interested can we have a chat session.

[tujoworker]

Gatsby has a working React v17 fork: https://www.npmjs.com/package/@gatsbyjs/reach-router

[Himadu2000]

Gatsby has a working React v17 fork: https://www.npmjs.com/package/@gatsbyjs/reach-router

Well it doesn't have typescript or even a link to repo or issue page.

[tujoworker]

Yes, very true. It’s not meant be be a replacement in any kind. I just wanted to mention it, because this PR is about React v17 compatibility.

[CWSites]

It'd be great to get rid of this warning...

warning "@storybook/addon-a11y > @storybook/api > @reach/router@1.3.4" has incorrect peer dependency "react@15.x || 16.x || 16.4.0-alpha.0911da3".
warning "@storybook/addon-a11y > @storybook/api > @reach/router@1.3.4" has incorrect peer dependency "react-dom@15.x || 16.x || 16.4.0-alpha.0911da3".

[Methuselah96]

Should be fixed when Storybook v6.4.0 is released thanks to storybookjs/storybook#16440.